All of lore.kernel.org
 help / color / mirror / Atom feed
From: Martin Willi <martin@strongswan.org>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: Steffen Klassert <steffen.klassert@secunet.com>,
	linux-crypto@vger.kernel.org
Subject: Re: [PATCH 3/9] crypto: Add a generic Poly1305 authenticator implementation
Date: Thu, 04 Jun 2015 21:42:31 +0200	[thread overview]
Message-ID: <1433446951.2945.6.camel@martin> (raw)
In-Reply-To: <20150604095910.GA24246@gondor.apana.org.au>

Herbert,

> I just realised that this doesn't quite work.  The key is shared
> by all users of the tfm, yet in your case you need it to be local

I agree, as Poly1305 uses a different key for each tag the current
approach doesn't work.

> I think the simplest solution is to make the key the beginning
> of the hashed text instead.  So the first two blocks that you
> process get used as the key.

Yes, that makes sense. I'll prepare a fix, might require some days,
though.

Thanks!
Martin

  reply	other threads:[~2015-06-04 19:52 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-01 11:43 [PATCH 0/9] crypto: Add ChaCha20-Poly1305 AEAD support for IPsec Martin Willi
2015-06-01 11:43 ` [PATCH 1/9] crypto: Add a generic ChaCha20 stream cipher implementation Martin Willi
2015-06-01 11:43 ` [PATCH 2/9] crypto: testmgr - Add ChaCha20 test vectors from RFC7539 Martin Willi
2015-06-01 11:43 ` [PATCH 3/9] crypto: Add a generic Poly1305 authenticator implementation Martin Willi
2015-06-04  9:59   ` Herbert Xu
2015-06-04 19:42     ` Martin Willi [this message]
2015-06-01 11:43 ` [PATCH 4/9] crypto: testmgr - Add Poly1305 test vectors from RFC7539 Martin Willi
2015-06-01 11:44 ` [PATCH 5/9] crypto: Add a ChaCha20-Poly1305 AEAD construction, RFC7539 Martin Willi
2015-06-01 11:44 ` [PATCH 6/9] crypto: testmgr - Add ChaCha20-Poly1305 test vectors from RFC7539 Martin Willi
2015-06-01 11:44 ` [PATCH 7/9] crypto: chacha20poly1305 - Add an IPsec variant for RFC7539 AEAD Martin Willi
2015-06-01 11:44 ` [PATCH 8/9] crypto: testmgr - Add draft-ietf-ipsecme-chacha20-poly1305 test vector Martin Willi
2015-06-01 11:44 ` [PATCH 9/9] xfrm: Define ChaCha20-Poly1305 AEAD XFRM algo for IPsec users Martin Willi
2015-06-03  2:44 ` [PATCH 0/9] crypto: Add ChaCha20-Poly1305 AEAD support for IPsec Herbert Xu
2015-06-03  7:53   ` Steffen Klassert
2015-06-04  8:13 ` Herbert Xu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1433446951.2945.6.camel@martin \
    --to=martin@strongswan.org \
    --cc=herbert@gondor.apana.org.au \
    --cc=linux-crypto@vger.kernel.org \
    --cc=steffen.klassert@secunet.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.