From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754170AbbFDWpv (ORCPT ); Thu, 4 Jun 2015 18:45:51 -0400 Received: from smtprelay0211.hostedemail.com ([216.40.44.211]:51461 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753847AbbFDWpu (ORCPT ); Thu, 4 Jun 2015 18:45:50 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::,RULES_HIT:41:355:379:541:599:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1539:1593:1594:1711:1730:1747:1777:1792:2393:2553:2559:2562:2828:3138:3139:3140:3141:3142:3352:3622:3865:3868:3870:3871:3872:4321:5007:6119:6261:7904:8660:10004:10400:10848:11232:11658:11914:12517:12519:12740:13069:13148:13230:13311:13357:21080,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0 X-HE-Tag: apple51_8a130cc92e80b X-Filterd-Recvd-Size: 1791 Message-ID: <1433457947.2658.9.camel@perches.com> Subject: Re: [RFC/PATCH 1/8] lib: string: Introduce strreplace From: Joe Perches To: Al Viro Cc: Rasmus Villemoes , Andrew Morton , Daniel Borkmann , Herbert Xu , linux-kernel@vger.kernel.org Date: Thu, 04 Jun 2015 15:45:47 -0700 In-Reply-To: <20150604223753.GO7232@ZenIV.linux.org.uk> References: <1433410636-26812-1-git-send-email-linux@rasmusvillemoes.dk> <1433410636-26812-2-git-send-email-linux@rasmusvillemoes.dk> <1433415367.4861.152.camel@perches.com> <20150604223753.GO7232@ZenIV.linux.org.uk> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.12.11-0ubuntu3 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2015-06-04 at 23:37 +0100, Al Viro wrote: > On Thu, Jun 04, 2015 at 03:56:07AM -0700, Joe Perches wrote: > > Seems sensible, but the name maybe could be be more > > explicit as strreplace seems like it should more like > > a string substitution rather than a char substitution. > > > > Maybe strsubstchr or something like it (strtranschr?) > > Why not go the full monty and call it strtrtsstrrrtst(), with > strtrtssstrrtst() doing almost, but not quite the same thing? Presumably the extra r is for reverse and the extra s in for insensitive, just because... Naming does matter. Consistency too. And for the consistency bit, the char arguments should probably be int.