From mboxrd@z Thu Jan 1 00:00:00 1970 From: Keller, Jacob E Date: Thu, 4 Jun 2015 23:28:09 +0000 Subject: [Intel-wired-lan] [PATCH] fm10k: Fix missing braces after if statement In-Reply-To: <20150604015219.2895.80478.stgit@ahduyck-vm-fedora22> References: <20150604015219.2895.80478.stgit@ahduyck-vm-fedora22> Message-ID: <1433460464.1500.4.camel@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: intel-wired-lan@osuosl.org List-ID: Acked-by: Jacob Keller Thanks Alex. Regards, Jake On Wed, 2015-06-03 at 18:53 -0700, Alexander Duyck wrote: > While reviewing the code I noticed that one of the commits added an if > statement followed by a for loop, but the if statement was missing the > braces around the loop. This change corrects the coding style error. > > Signed-off-by: Alexander Duyck > --- > drivers/net/ethernet/intel/fm10k/fm10k_ethtool.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/intel/fm10k/fm10k_ethtool.c b/drivers/net/ethernet/intel/fm10k/fm10k_ethtool.c > index 4b9d9f88af70..a9670e00cf03 100644 > --- a/drivers/net/ethernet/intel/fm10k/fm10k_ethtool.c > +++ b/drivers/net/ethernet/intel/fm10k/fm10k_ethtool.c > @@ -143,12 +143,13 @@ static void fm10k_get_strings(struct net_device *dev, u32 stringset, u8 *data) > p += ETH_GSTRING_LEN; > } > > - if (interface->hw.mac.type != fm10k_mac_vf) > + if (interface->hw.mac.type != fm10k_mac_vf) { > for (i = 0; i < FM10K_PF_STATS_LEN; i++) { > memcpy(p, fm10k_gstrings_pf_stats[i].stat_string, > ETH_GSTRING_LEN); > p += ETH_GSTRING_LEN; > } > + } > > for (i = 0; i < interface->hw.mac.max_queues; i++) { > sprintf(p, "tx_queue_%u_packets", i); > > _______________________________________________ > Intel-wired-lan mailing list > Intel-wired-lan at lists.osuosl.org > http://lists.osuosl.org/mailman/listinfo/intel-wired-lan From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Keller, Jacob E" Subject: Re: [Intel-wired-lan] [PATCH] fm10k: Fix missing braces after if statement Date: Thu, 4 Jun 2015 23:28:09 +0000 Message-ID: <1433460464.1500.4.camel@intel.com> References: <20150604015219.2895.80478.stgit@ahduyck-vm-fedora22> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Cc: "davem@davemloft.net" , "Kirsher, Jeffrey T" , "intel-wired-lan@lists.osuosl.org" , "netdev@vger.kernel.org" To: "alexander.h.duyck@redhat.com" Return-path: Received: from mga11.intel.com ([192.55.52.93]:49838 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752773AbbFDX2L (ORCPT ); Thu, 4 Jun 2015 19:28:11 -0400 In-Reply-To: <20150604015219.2895.80478.stgit@ahduyck-vm-fedora22> Content-Language: en-US Content-ID: <40EDAE4BB8640C4D865CAD2CAEEC33CF@intel.com> Sender: netdev-owner@vger.kernel.org List-ID: QWNrZWQtYnk6IEphY29iIEtlbGxlciA8amFjb2IuZS5rZWxsZXJAaW50ZWwuY29tPg0KDQpUaGFu a3MgQWxleC4NCg0KUmVnYXJkcywNCkpha2UNCg0KT24gV2VkLCAyMDE1LTA2LTAzIGF0IDE4OjUz IC0wNzAwLCBBbGV4YW5kZXIgRHV5Y2sgd3JvdGU6DQo+IFdoaWxlIHJldmlld2luZyB0aGUgY29k ZSBJIG5vdGljZWQgdGhhdCBvbmUgb2YgdGhlIGNvbW1pdHMgYWRkZWQgYW4gaWYNCj4gc3RhdGVt ZW50IGZvbGxvd2VkIGJ5IGEgZm9yIGxvb3AsIGJ1dCB0aGUgaWYgc3RhdGVtZW50IHdhcyBtaXNz aW5nIHRoZQ0KPiBicmFjZXMgYXJvdW5kIHRoZSBsb29wLiAgVGhpcyBjaGFuZ2UgY29ycmVjdHMg dGhlIGNvZGluZyBzdHlsZSBlcnJvci4NCj4gDQo+IFNpZ25lZC1vZmYtYnk6IEFsZXhhbmRlciBE dXljayA8YWxleGFuZGVyLmguZHV5Y2tAcmVkaGF0LmNvbT4NCj4gLS0tDQo+ICBkcml2ZXJzL25l dC9ldGhlcm5ldC9pbnRlbC9mbTEway9mbTEwa19ldGh0b29sLmMgfCAgICAzICsrLQ0KPiAgMSBm aWxlIGNoYW5nZWQsIDIgaW5zZXJ0aW9ucygrKSwgMSBkZWxldGlvbigtKQ0KPiANCj4gZGlmZiAt LWdpdCBhL2RyaXZlcnMvbmV0L2V0aGVybmV0L2ludGVsL2ZtMTBrL2ZtMTBrX2V0aHRvb2wuYyBi L2RyaXZlcnMvbmV0L2V0aGVybmV0L2ludGVsL2ZtMTBrL2ZtMTBrX2V0aHRvb2wuYw0KPiBpbmRl eCA0YjlkOWY4OGFmNzAuLmE5NjcwZTAwY2YwMyAxMDA2NDQNCj4gLS0tIGEvZHJpdmVycy9uZXQv ZXRoZXJuZXQvaW50ZWwvZm0xMGsvZm0xMGtfZXRodG9vbC5jDQo+ICsrKyBiL2RyaXZlcnMvbmV0 L2V0aGVybmV0L2ludGVsL2ZtMTBrL2ZtMTBrX2V0aHRvb2wuYw0KPiBAQCAtMTQzLDEyICsxNDMs MTMgQEAgc3RhdGljIHZvaWQgZm0xMGtfZ2V0X3N0cmluZ3Moc3RydWN0IG5ldF9kZXZpY2UgKmRl diwgdTMyIHN0cmluZ3NldCwgdTggKmRhdGEpDQo+ICAJCQlwICs9IEVUSF9HU1RSSU5HX0xFTjsN Cj4gIAkJfQ0KPiAgDQo+IC0JCWlmIChpbnRlcmZhY2UtPmh3Lm1hYy50eXBlICE9IGZtMTBrX21h Y192ZikNCj4gKwkJaWYgKGludGVyZmFjZS0+aHcubWFjLnR5cGUgIT0gZm0xMGtfbWFjX3ZmKSB7 DQo+ICAJCQlmb3IgKGkgPSAwOyBpIDwgRk0xMEtfUEZfU1RBVFNfTEVOOyBpKyspIHsNCj4gIAkJ CQltZW1jcHkocCwgZm0xMGtfZ3N0cmluZ3NfcGZfc3RhdHNbaV0uc3RhdF9zdHJpbmcsDQo+ICAJ CQkJICAgICAgIEVUSF9HU1RSSU5HX0xFTik7DQo+ICAJCQkJcCArPSBFVEhfR1NUUklOR19MRU47 DQo+ICAJCQl9DQo+ICsJCX0NCj4gIA0KPiAgCQlmb3IgKGkgPSAwOyBpIDwgaW50ZXJmYWNlLT5o dy5tYWMubWF4X3F1ZXVlczsgaSsrKSB7DQo+ICAJCQlzcHJpbnRmKHAsICJ0eF9xdWV1ZV8ldV9w YWNrZXRzIiwgaSk7DQo+IA0KPiBfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fXw0KPiBJbnRlbC13aXJlZC1sYW4gbWFpbGluZyBsaXN0DQo+IEludGVsLXdpcmVk LWxhbkBsaXN0cy5vc3Vvc2wub3JnDQo+IGh0dHA6Ly9saXN0cy5vc3Vvc2wub3JnL21haWxtYW4v bGlzdGluZm8vaW50ZWwtd2lyZWQtbGFuDQoNCg==