All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tiejun Chen <tiejun.chen@intel.com>
To: mst@redhat.com, pbonzini@redhat.com, rth@twiddle.net,
	ehabkost@redhat.com
Cc: qemu-devel@nongnu.org
Subject: [Qemu-devel] [v8][RESEND][PATCH 02/10] pc_init1: pass parameters just with types
Date: Fri,  5 Jun 2015 16:44:53 +0800	[thread overview]
Message-ID: <1433493901-9332-3-git-send-email-tiejun.chen@intel.com> (raw)
In-Reply-To: <1433493901-9332-1-git-send-email-tiejun.chen@intel.com>

Pass types to configure pc_init1().

Signed-off-by: Tiejun Chen <tiejun.chen@intel.com>
---
 hw/i386/pc_piix.c | 14 ++++++++------
 1 file changed, 8 insertions(+), 6 deletions(-)

diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c
index c05b7c7..3e2fc04 100644
--- a/hw/i386/pc_piix.c
+++ b/hw/i386/pc_piix.c
@@ -75,7 +75,8 @@ static bool has_reserved_memory = true;
 static bool kvmclock_enabled = true;
 
 /* PC hardware initialisation */
-static void pc_init1(MachineState *machine)
+static void pc_init1(MachineState *machine,
+                     const char *host_type, const char *pci_type)
 {
     PCMachineState *pc_machine = PC_MACHINE(machine);
     MemoryRegion *system_memory = get_system_memory();
@@ -202,8 +203,8 @@ static void pc_init1(MachineState *machine)
     }
 
     if (pci_enabled) {
-        pci_bus = i440fx_init(TYPE_I440FX_PCI_HOST_BRIDGE,
-                              TYPE_I440FX_PCI_DEVICE,
+        pci_bus = i440fx_init(host_type,
+                              pci_type,
                               &i440fx_state, &piix3_devfn, &isa_bus, gsi,
                               system_memory, system_io, machine->ram_size,
                               below_4g_mem_size,
@@ -437,7 +438,7 @@ static void pc_init_isa(MachineState *machine)
     }
     x86_cpu_compat_kvm_no_autoenable(FEAT_KVM, 1 << KVM_FEATURE_PV_EOI);
     enable_compat_apic_id_mode();
-    pc_init1(machine);
+    pc_init1(machine, TYPE_I440FX_PCI_HOST_BRIDGE, TYPE_I440FX_PCI_DEVICE);
 }
 
 #ifdef CONFIG_XEN
@@ -445,7 +446,7 @@ static void pc_xen_hvm_init(MachineState *machine)
 {
     PCIBus *bus;
 
-    pc_init1(machine);
+    pc_init1(machine, TYPE_I440FX_PCI_HOST_BRIDGE, TYPE_I440FX_PCI_DEVICE);
 
     bus = pci_find_primary_bus();
     if (bus != NULL) {
@@ -461,7 +462,8 @@ static void pc_xen_hvm_init(MachineState *machine)
         if (compat) { \
             compat(machine); \
         } \
-        pc_init1(machine); \
+        pc_init1(machine, TYPE_I440FX_PCI_HOST_BRIDGE, \
+                 TYPE_I440FX_PCI_DEVICE); \
     } \
     DEFINE_PC_MACHINE(suffix, name, pc_init_##suffix, optionfn)
 
-- 
1.9.1

  parent reply	other threads:[~2015-06-05  8:48 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-05  8:44 [Qemu-devel] [v8][RESEND][PATCH 00/10] xen: add Intel IGD passthrough Tiejun Chen
2015-06-05  8:44 ` [Qemu-devel] [v8][RESEND][PATCH 01/10] i440fx: make types configurable at run-time Tiejun Chen
2015-06-05  8:44 ` Tiejun Chen [this message]
2015-06-05  8:44 ` [Qemu-devel] [v8][RESEND][PATCH 03/10] piix: create host bridge to passthrough Tiejun Chen
2015-06-05  8:44 ` [Qemu-devel] [v8][RESEND][PATCH 04/10] hw/pci-assign: split pci-assign.c Tiejun Chen
2015-06-05  8:44 ` [Qemu-devel] [v8][RESEND][PATCH 05/10] xen, gfx passthrough: basic graphics passthrough support Tiejun Chen
2015-07-01 15:45   ` Stefano Stabellini
2015-06-05  8:44 ` [Qemu-devel] [v8][RESEND][PATCH 06/10] xen, gfx passthrough: retrieve VGA BIOS to work Tiejun Chen
2015-07-01 15:51   ` Stefano Stabellini
2015-06-05  8:44 ` [Qemu-devel] [v8][RESEND][PATCH 07/10] igd gfx passthrough: create a isa bridge Tiejun Chen
2015-06-05  8:44 ` [Qemu-devel] [v8][RESEND][PATCH 08/10] xen, gfx passthrough: register " Tiejun Chen
2015-07-01 15:55   ` Stefano Stabellini
2015-07-03  1:51     ` Chen, Tiejun
2015-06-05  8:45 ` [Qemu-devel] [v8][RESEND][PATCH 09/10] xen, gfx passthrough: register host bridge specific to passthrough Tiejun Chen
2015-07-01 15:58   ` Stefano Stabellini
2015-07-03  3:11     ` Chen, Tiejun
2015-06-05  8:45 ` [Qemu-devel] [v8][RESEND][PATCH 10/10] xen, gfx passthrough: add opregion mapping Tiejun Chen
2015-07-01 16:01   ` Stefano Stabellini
2015-07-01  1:39 ` [Qemu-devel] [v8][RESEND][PATCH 00/10] xen: add Intel IGD passthrough Chen, Tiejun
2015-07-01 16:03   ` Stefano Stabellini
2015-07-03  3:17     ` Chen, Tiejun
2015-07-02  6:22 ` Michael S. Tsirkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1433493901-9332-3-git-send-email-tiejun.chen@intel.com \
    --to=tiejun.chen@intel.com \
    --cc=ehabkost@redhat.com \
    --cc=mst@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=rth@twiddle.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.