From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH v11 6/9] xen: Add ring 3 vmware_port support Date: Fri, 5 Jun 2015 11:54:02 +0100 Message-ID: <1433501642.7108.211.camel@citrix.com> References: <1432309826-6420-1-git-send-email-dslutz@verizon.com> <1432309826-6420-7-git-send-email-dslutz@verizon.com> <556F1C8B.6030004@eu.citrix.com> <556F2434.60004@citrix.com> <556F2D27.1060301@Gmail.com> <556F303F.6040707@eu.citrix.com> <557188840200007800081342@mail.emea.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <557188840200007800081342@mail.emea.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Jan Beulich Cc: Jun Nakajima , Tim Deegan , Kevin Tian , Keir Fraser , Eddie Dong , Stefano Stabellini , George Dunlap , Andrew Cooper , Ian Jackson , Don Slutz , Don Slutz , xen-devel@lists.xen.org, Aravind Gopalakrishnan , Suravee Suthikulpanit , BorisOstrovsky List-Id: xen-devel@lists.xenproject.org On Fri, 2015-06-05 at 10:31 +0100, Jan Beulich wrote: > > I'm talking about cost-benefits analysis. What's the benefit of > > accepting this patch, and is it worth the cost? > > The basic idea of allowing guests originally having got installed on > VMware to continue their lives on Xen is certainly something worth > accepting some cost. It's really hard to judge whether in the case > here things go too far (and that would equally apply to the hand > crafted instruction decoding done in earlier versions of this series). I can see the benefit in having a guest which was installed on vmware be able to boot and work on Xen. But AIUI this userspace vmware port thing is not needed for that basic use case but instead goes farther and enables advanced features like clip boards integration, which TBH I think we could consider living without (especially considering the costs discussed here). It would be really useful to see a comprehensive list of exactly what guest ring3 access to the vmware port actually enables i.e. a list of specific features which require it. Ian.