From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <ian.campbell@citrix.com>
Subject: Re: [PATCH V6 09/10] xen/arm: make domain_max_vcpus
 return value from vgic_ops
Date: Fri, 5 Jun 2015 17:26:24 +0100
Message-ID: <1433521584.7108.350.camel@citrix.com>
References: <1433163388-16970-1-git-send-email-cbz@baozis.org>
	<1433163388-16970-10-git-send-email-cbz@baozis.org>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta3.messagelabs.com ([195.245.230.39])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <prvs=591267e2d=Ian.Campbell@citrix.com>)
	id 1Z0uUy-0006QZ-3j
	for xen-devel@lists.xenproject.org; Fri, 05 Jun 2015 16:29:36 +0000
In-Reply-To: <1433163388-16970-10-git-send-email-cbz@baozis.org>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Chen Baozi <cbz@baozis.org>
Cc: Julien Grall <julien.grall@citrix.com>, xen-devel@lists.xenproject.org, Chen Baozi <baozich@gmail.com>
List-Id: xen-devel@lists.xenproject.org

On Mon, 2015-06-01 at 20:56 +0800, Chen Baozi wrote:
> [...] 
> +#define GICV2_MAX_CPUS  8

This and GICV3_MAX_CPUS don't seem very worthwhile, unless there are to
be other uses of them.

In fact, GICV3_MAX_CPUS is really MAX_VIRT_CPUS, through it's
association with the affinity mapping, i.e. if one changes so would the
other, in lockstep. So I think you should just use that for v3 and
hardcode 8 inline for v2 (since it cannot change).

Ian.