From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH V6 01/10] xen/arm: gic-v3: Increase the size of GICR in address space for guest Date: Fri, 5 Jun 2015 17:31:03 +0100 Message-ID: <1433521863.7108.354.camel@citrix.com> References: <1433163388-16970-1-git-send-email-cbz@baozis.org> <1433163388-16970-2-git-send-email-cbz@baozis.org> <1433519363.7108.322.camel@citrix.com> <5571C8A9.6070903@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1Z0uXt-00075u-Nu for xen-devel@lists.xenproject.org; Fri, 05 Jun 2015 16:32:37 +0000 In-Reply-To: <5571C8A9.6070903@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Julien Grall Cc: xen-devel@lists.xenproject.org, Chen Baozi , Chen Baozi List-Id: xen-devel@lists.xenproject.org On Fri, 2015-06-05 at 17:04 +0100, Julien Grall wrote: > On 05/06/15 16:49, Ian Campbell wrote: > > On Mon, 2015-06-01 at 20:56 +0800, Chen Baozi wrote: > >> From: Chen Baozi > >> > >> Currently it only supports up to 8 vCPUs. Increase the region to hold > >> up to 128 vCPUs, which is the maximum number that GIC-500 supports. > >> > >> Signed-off-by: Chen Baozi > >> Reviewed-by: Julien Grall > > > > Acked-by: Ian Campbell > > > > I did briefly wonder if we should shoot for the stars here and reserve > > space for some enormous set of processors, but I suppose there's no > > need. > > I though about the same things. AFF0 + AFF1 gives 4096 CPUs. > > Although as we will support only 128 vCPUs (see the last patch), > reserving more space is not necessary. This space saved can be used for > a bigger PCI MMIO region later. I don't think rdistr regions need to be contiguous, so we could consider (not now, when it happens) putting CPUs 128+ into the gap above 4G, on the basis that a guest with that many CPUs is almost certainly going to have tonnes of RAM and therefore be 64 bit... Ian.