From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <ian.campbell@citrix.com>
Subject: Re: [RFC 21/22] arm: Allow the user to specify the GIC
 version
Date: Fri, 5 Jun 2015 17:40:10 +0100
Message-ID: <1433522410.7108.360.camel@citrix.com>
References: <1431091783-29090-1-git-send-email-julien.grall@citrix.com>
	<1431091783-29090-22-git-send-email-julien.grall@citrix.com>
	<1433508170.7108.270.camel@citrix.com> <5571C784.5030406@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta5.messagelabs.com ([195.245.231.135])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <prvs=591267e2d=Ian.Campbell@citrix.com>)
	id 1Z0uff-0008CC-Tl
	for xen-devel@lists.xenproject.org; Fri, 05 Jun 2015 16:40:40 +0000
In-Reply-To: <5571C784.5030406@citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Julien Grall <julien.grall@citrix.com>
Cc: xen-devel@lists.xenproject.org, tim@xen.org, Ian Jackson <ian.jackson@eu.citrix.com>, stefano.stabellini@citrix.com, Wei Liu <wei.liu2@citrix.com>
List-Id: xen-devel@lists.xenproject.org

On Fri, 2015-06-05 at 17:00 +0100, Julien Grall wrote:
> >> diff --git a/tools/libxl/xl_cmdimpl.c b/tools/libxl/xl_cmdimpl.c
> >> index 648ca08..b033c0b 100644
> >> --- a/tools/libxl/xl_cmdimpl.c
> >> +++ b/tools/libxl/xl_cmdimpl.c
> >> @@ -1298,6 +1298,18 @@ static void parse_config_data(const char *config_source,
> >>          !xlu_cfg_get_string (config, "cpus_soft", &buf, 0))
> >>          parse_vcpu_affinity(b_info, cpus, buf, num_cpus, false);
> >>  
> >> +    if (!xlu_cfg_get_string (config, "gic_version", &buf, 1)) {
> > 
> > Could we just make this an integer?
> 
> I choose the string solution over integer to not rule out the
> possibility to expose to the user a specific extension of the GICvn
> (such as V2M or ITS).

IMHO those should be separate booleans or options, but you are right
that I suppose we don't know that gicv5 won't be called the wombat
interrupt controller instead of v5.

Ian.