All of lore.kernel.org
 help / color / mirror / Atom feed
From: Richard Weinberger <richard@nod.at>
To: Masahiro Yamada <yamada.masahiro@socionext.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Kate Stewart <kstewart@linuxfoundation.org>,
	Nicholas Piggin <npiggin@gmail.com>,
	Kees Cook <keescook@chromium.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	david@sigma-star.at, kbuild-all@01.org,
	Sam Ravnborg <sam@ravnborg.org>,
	Arnaud Lacombe <lacombar@gmail.com>,
	Nick Bowler <nbowler@elliptictech.com>,
	Michal Marek <mmarek@suse.cz>, Nicolas Pitre <nico@linaro.org>,
	Rusty Russell <rusty@rustcorp.com.au>
Subject: Re: [PATCH v2] kbuild: Don't source kernel config
Date: Tue, 20 Feb 2018 16:25:32 +0100	[thread overview]
Message-ID: <14335276.CH3Xr2i6I8@blindfold> (raw)
In-Reply-To: <CAK7LNASLQnWFO+qA94ifX8Gv1vMxGE-BOEhh1x2P-_mMUWRbAw@mail.gmail.com>

Am Dienstag, 20. Februar 2018, 16:18:11 CET schrieb Masahiro Yamada:
> 2018-02-19 18:22 GMT+09:00 Richard Weinberger <richard@nod.at>:
> > Don't source the kernel config file in shell scripts.
> > The config file is not a shell script and often imported from untrusted
> > sources.
> > What could possible go wrong? ;-)
> 
> Please enumerate your real problems.

Build a kernel where the .config contains something like:
CONFIG_CMDLINE_BOOL=y
CONFIG_CMDLINE="`echo hello > world`"

I'll send a v3 because I forgot to convert one function in the shell script to 
the new bash array. kbuild bot FTW. :-)

Thanks,
//richard

  reply	other threads:[~2018-02-20 15:25 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-19  9:22 [PATCH v2] kbuild: Don't source kernel config Richard Weinberger
2018-02-20 15:18 ` Masahiro Yamada
2018-02-20 15:25   ` Richard Weinberger [this message]
2018-02-20 16:00     ` Masahiro Yamada
2018-02-20 16:16       ` Richard Weinberger
2018-02-20 16:26         ` Nicolas Pitre
2018-02-20 16:30         ` Masahiro Yamada
2018-02-20 16:55           ` Richard Weinberger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=14335276.CH3Xr2i6I8@blindfold \
    --to=richard@nod.at \
    --cc=akpm@linux-foundation.org \
    --cc=david@sigma-star.at \
    --cc=gregkh@linuxfoundation.org \
    --cc=kbuild-all@01.org \
    --cc=keescook@chromium.org \
    --cc=kstewart@linuxfoundation.org \
    --cc=lacombar@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mmarek@suse.cz \
    --cc=nbowler@elliptictech.com \
    --cc=nico@linaro.org \
    --cc=npiggin@gmail.com \
    --cc=rusty@rustcorp.com.au \
    --cc=sam@ravnborg.org \
    --cc=yamada.masahiro@socionext.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.