All of lore.kernel.org
 help / color / mirror / Atom feed
From: Gerd Hoffmann <kraxel@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>,
	"Gabriel L. Somlo" <gsomlo@gmail.com>
Cc: QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PULL 0/6] fw_cfg patch queue
Date: Mon, 08 Jun 2015 14:26:03 +0200	[thread overview]
Message-ID: <1433766363.5046.37.camel@redhat.com> (raw)
In-Reply-To: <CAFEAcA-SmWxuab2ny2SuN-hPnaEUqNfTdFo3PrK=w1=YnzQAOg@mail.gmail.com>

> Hi. I'm afraid this fails make check for me:
> 
> GTESTER check-qtest-ppc
> qemu-system-ppc:
> /home/petmay01/linaro/qemu-for-merges/hw/nvram/fw_cfg.c:426:
> fw_cfg_add_bytes_read_callback: Assertion `s->entries[arch][key].data
> == ((void *)0)' failed.
> Broken pipe
> GTester: last random seed: R02Sd9273ba718a6b28ff4381eed659a0cb4
> qemu-system-ppc:
> /home/petmay01/linaro/qemu-for-merges/hw/nvram/fw_cfg.c:426:
> fw_cfg_add_bytes_read_callback: Assertion `s->entries[arch][key].data
> == ((void *)0)' failed.
> Broken pipe
> GTester: last random seed: R02S59d67a130b823e6e6d04a41eb4b168c7

Reproducer: "qemu-system-ppc -M g3beige -boot once=d,order=c".
Culprit: Patch #3 (fw_cfg: prevent selector key conflict).
Looks like FW_CFG_BOOT_DEVICE is set twice for macs.

Gabriel?  To me this looks like the assert found an actual bug ...

cheers,
  Gerd

  reply	other threads:[~2015-06-08 12:26 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-05 14:14 [Qemu-devel] [PULL 0/6] fw_cfg patch queue Gerd Hoffmann
2015-06-05 14:14 ` [Qemu-devel] [PULL 1/6] QemuOpts: increase number of vm_config_groups Gerd Hoffmann
2015-06-05 14:14 ` [Qemu-devel] [PULL 2/6] fw_cfg: remove support for guest-side data writes Gerd Hoffmann
2015-06-05 14:20   ` Gabriel L. Somlo
2015-06-08 12:30     ` Gerd Hoffmann
2015-06-05 14:14 ` [Qemu-devel] [PULL 3/6] fw_cfg: prevent selector key conflict Gerd Hoffmann
2015-06-05 14:14 ` [Qemu-devel] [PULL 4/6] fw_cfg: prohibit insertion of duplicate fw_cfg file names Gerd Hoffmann
2015-06-05 14:14 ` [Qemu-devel] [PULL 5/6] fw_cfg: insert fw_cfg file blobs via qemu cmdline Gerd Hoffmann
2015-06-05 14:14 ` [Qemu-devel] [PULL 6/6] bios-tables-test: handle false-positive smbios signature matches Gerd Hoffmann
2015-06-05 16:14 ` [Qemu-devel] [PULL 0/6] fw_cfg patch queue Peter Maydell
2015-06-08 12:26   ` Gerd Hoffmann [this message]
2015-06-08 17:44     ` Gabriel L. Somlo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1433766363.5046.37.camel@redhat.com \
    --to=kraxel@redhat.com \
    --cc=gsomlo@gmail.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.