From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Ingo Molnar <mingo@kernel.org>
Cc: linux-kernel@vger.kernel.org, Jiri Olsa <jolsa@kernel.org>,
Andi Kleen <ak@linux.intel.com>, David Ahern <dsahern@gmail.com>,
Namhyung Kim <namhyung@kernel.org>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Stephane Eranian <eranian@google.com>,
Arnaldo Carvalho de Melo <acme@redhat.com>
Subject: [PATCH 08/15] perf stat: Add aggr_mode argument to print_shadow_stats function
Date: Mon, 8 Jun 2015 11:17:09 -0300 [thread overview]
Message-ID: <1433773036-11525-9-git-send-email-acme@kernel.org> (raw)
In-Reply-To: <1433773036-11525-1-git-send-email-acme@kernel.org>
From: Jiri Olsa <jolsa@kernel.org>
As preparation for moving shadow counters code into its own object.
Signed-off-by: Jiri Olsa <jolsa@kernel.org>
Cc: Andi Kleen <ak@linux.intel.com>
Cc: David Ahern <dsahern@gmail.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Stephane Eranian <eranian@google.com>
Link: http://lkml.kernel.org/r/1433341559-31848-9-git-send-email-jolsa@kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
tools/perf/builtin-stat.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/tools/perf/builtin-stat.c b/tools/perf/builtin-stat.c
index 14a75ddb60c7..50918dc9fb31 100644
--- a/tools/perf/builtin-stat.c
+++ b/tools/perf/builtin-stat.c
@@ -1059,7 +1059,8 @@ static void print_ll_cache_misses(FILE *out, int cpu,
fprintf(out, " of all LL-cache hits ");
}
-static void print_shadow_stats(FILE *out, struct perf_evsel *evsel, double avg, int cpu)
+static void print_shadow_stats(FILE *out, struct perf_evsel *evsel,
+ double avg, int cpu, enum aggr_mode aggr)
{
double total, ratio = 0.0, total2;
int ctx = evsel_context(evsel);
@@ -1078,7 +1079,7 @@ static void print_shadow_stats(FILE *out, struct perf_evsel *evsel, double avg,
if (total && avg) {
ratio = total / avg;
fprintf(out, "\n");
- if (aggr_mode == AGGR_NONE)
+ if (aggr == AGGR_NONE)
fprintf(out, " ");
fprintf(out, " # %5.2f stalled cycles per insn", ratio);
}
@@ -1229,7 +1230,7 @@ static void abs_printout(int id, int nr, struct perf_evsel *evsel, double avg)
if (csv_output || interval)
return;
- print_shadow_stats(output, evsel, avg, cpu);
+ print_shadow_stats(output, evsel, avg, cpu, aggr_mode);
}
static void print_aggr(char *prefix)
--
2.1.0
next prev parent reply other threads:[~2015-06-08 14:20 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-08 14:17 [GIT PULL 00/15] perf/core improvements and fixes Arnaldo Carvalho de Melo
2015-06-08 14:17 ` [PATCH 01/15] perf stat: Add id into perf_stat struct Arnaldo Carvalho de Melo
2015-06-08 14:17 ` [PATCH 02/15] perf stat: Replace transaction event possition check with id check Arnaldo Carvalho de Melo
2015-06-08 14:17 ` [PATCH 03/15] perf stat: Remove setup_events function Arnaldo Carvalho de Melo
2015-06-08 14:17 ` [PATCH 04/15] perf stat: Remove transaction_run from shadow update/print code Arnaldo Carvalho de Melo
2015-06-08 14:17 ` [PATCH 05/15] perf stat: Introduce reset_shadow_stats function Arnaldo Carvalho de Melo
2015-06-08 14:17 ` [PATCH 06/15] perf stat: Introduce print_shadow_stats function Arnaldo Carvalho de Melo
2015-06-08 14:17 ` [PATCH 07/15] perf stat: Add output file argument to " Arnaldo Carvalho de Melo
2015-06-08 14:17 ` Arnaldo Carvalho de Melo [this message]
2015-06-08 14:17 ` [PATCH 09/15] perf stat: Move shadow stat counters into separate object Arnaldo Carvalho de Melo
2015-06-08 14:17 ` [PATCH 10/15] tools lib traceevent: Export dynamic symbols used by traceevent plugins Arnaldo Carvalho de Melo
2015-06-08 14:17 ` [PATCH 11/15] tools lib traceevent: Ignore libtrace-dynamic-list file Arnaldo Carvalho de Melo
2015-06-08 14:17 ` [PATCH 12/15] perf record: Fix perf.data size in no-buildid mode Arnaldo Carvalho de Melo
2015-06-08 14:17 ` [PATCH 13/15] perf machine: Fix up some more method names Arnaldo Carvalho de Melo
2015-06-08 14:17 ` [PATCH 14/15] perf tools: Protect accesses the dso rbtrees/lists with a rw lock Arnaldo Carvalho de Melo
2015-06-08 14:17 ` [PATCH 15/15] perf tools: Reference count struct dso Arnaldo Carvalho de Melo
2015-06-09 9:47 ` [GIT PULL 00/15] perf/core improvements and fixes Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1433773036-11525-9-git-send-email-acme@kernel.org \
--to=acme@kernel.org \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@redhat.com \
--cc=ak@linux.intel.com \
--cc=dsahern@gmail.com \
--cc=eranian@google.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.