From mboxrd@z Thu Jan 1 00:00:00 1970 From: Benjamin Herrenschmidt Date: Mon, 08 Jun 2015 21:21:57 +0000 Subject: Re: [PATCH -next] fbdev: radeon: Avoid 64 bit divide Message-Id: <1433798517.4526.170.camel@kernel.crashing.org> List-Id: References: <1433527521-5384-1-git-send-email-linux@roeck-us.net> <1433534917.4526.105.camel@kernel.crashing.org> <5572053A.6060903@roeck-us.net> In-Reply-To: <5572053A.6060903@roeck-us.net> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Guenter Roeck Cc: Jean-Christophe Plagniol-Villard , Tomi Valkeinen , linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org, Tina Ruchandani On Fri, 2015-06-05 at 13:23 -0700, Guenter Roeck wrote: > On 06/05/2015 01:08 PM, Benjamin Herrenschmidt wrote: > > On Fri, 2015-06-05 at 11:05 -0700, Guenter Roeck wrote: > >> A 64 bit divide causes build failures with 32 bit builds, such as > >> > >> ERROR: "__divdi3" [drivers/video/fbdev/aty/radeonfb.ko] undefined! > >> > >> or > >> > >> drivers/built-in.o: In function `radeon_probe_pll_params': > >> radeon_base.c:(.text+0x16608b): undefined reference to `__divdi3' > > > > What about using do_div() instead ? > > > > delta is known to be <= 10*1000000, so I figured that would have been overkill. > But, sure, at the end it is the same. Want me to resubmit ? Don't bother. > Guenter > > >> Fixes: ce8f4069dce8 ("fbdev: radeon: Remove 'struct timeval' usage") > >> Cc: Tina Ruchandani > >> Signed-off-by: Guenter Roeck > >> --- > >> drivers/video/fbdev/aty/radeon_base.c | 2 +- > >> 1 file changed, 1 insertion(+), 1 deletion(-) > >> > >> diff --git a/drivers/video/fbdev/aty/radeon_base.c b/drivers/video/fbdev/aty/radeon_base.c > >> index b3612e30d74f..374e47532035 100644 > >> --- a/drivers/video/fbdev/aty/radeon_base.c > >> +++ b/drivers/video/fbdev/aty/radeon_base.c > >> @@ -492,7 +492,7 @@ static int radeon_probe_pll_params(struct radeonfb_info *rinfo) > >> /* Return -1 if more than 10 seconds have elapsed */ > >> if (delta > (10*1000000)) > >> return -1; > >> - hz = 1000000/delta; > >> + hz = 1000000 / (int)delta; > >> > >> hTotal = ((INREG(CRTC_H_TOTAL_DISP) & 0x1ff) + 1) * 8; > >> vTotal = ((INREG(CRTC_V_TOTAL_DISP) & 0x3ff) + 1); > > > > > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932187AbbFHVWY (ORCPT ); Mon, 8 Jun 2015 17:22:24 -0400 Received: from gate.crashing.org ([63.228.1.57]:38464 "EHLO gate.crashing.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752382AbbFHVWS (ORCPT ); Mon, 8 Jun 2015 17:22:18 -0400 Message-ID: <1433798517.4526.170.camel@kernel.crashing.org> Subject: Re: [PATCH -next] fbdev: radeon: Avoid 64 bit divide From: Benjamin Herrenschmidt To: Guenter Roeck Cc: Jean-Christophe Plagniol-Villard , Tomi Valkeinen , linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org, Tina Ruchandani Date: Tue, 09 Jun 2015 07:21:57 +1000 In-Reply-To: <5572053A.6060903@roeck-us.net> References: <1433527521-5384-1-git-send-email-linux@roeck-us.net> <1433534917.4526.105.camel@kernel.crashing.org> <5572053A.6060903@roeck-us.net> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.12.11-0ubuntu3 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2015-06-05 at 13:23 -0700, Guenter Roeck wrote: > On 06/05/2015 01:08 PM, Benjamin Herrenschmidt wrote: > > On Fri, 2015-06-05 at 11:05 -0700, Guenter Roeck wrote: > >> A 64 bit divide causes build failures with 32 bit builds, such as > >> > >> ERROR: "__divdi3" [drivers/video/fbdev/aty/radeonfb.ko] undefined! > >> > >> or > >> > >> drivers/built-in.o: In function `radeon_probe_pll_params': > >> radeon_base.c:(.text+0x16608b): undefined reference to `__divdi3' > > > > What about using do_div() instead ? > > > > delta is known to be <= 10*1000000, so I figured that would have been overkill. > But, sure, at the end it is the same. Want me to resubmit ? Don't bother. > Guenter > > >> Fixes: ce8f4069dce8 ("fbdev: radeon: Remove 'struct timeval' usage") > >> Cc: Tina Ruchandani > >> Signed-off-by: Guenter Roeck > >> --- > >> drivers/video/fbdev/aty/radeon_base.c | 2 +- > >> 1 file changed, 1 insertion(+), 1 deletion(-) > >> > >> diff --git a/drivers/video/fbdev/aty/radeon_base.c b/drivers/video/fbdev/aty/radeon_base.c > >> index b3612e30d74f..374e47532035 100644 > >> --- a/drivers/video/fbdev/aty/radeon_base.c > >> +++ b/drivers/video/fbdev/aty/radeon_base.c > >> @@ -492,7 +492,7 @@ static int radeon_probe_pll_params(struct radeonfb_info *rinfo) > >> /* Return -1 if more than 10 seconds have elapsed */ > >> if (delta > (10*1000000)) > >> return -1; > >> - hz = 1000000/delta; > >> + hz = 1000000 / (int)delta; > >> > >> hTotal = ((INREG(CRTC_H_TOTAL_DISP) & 0x1ff) + 1) * 8; > >> vTotal = ((INREG(CRTC_V_TOTAL_DISP) & 0x3ff) + 1); > > > > > >