Re: [OSSTEST Nested PATCH v11 4/7] Changes on test step of Debian hvm guest install

[Ian Campbell <ian.campbell@citrix.com>]

On Tue, 2015-06-09 at 05:29 +0000, Pang, LongtaoX wrote:
> 
> 
> > -----Original Message-----
> > From: Ian Campbell [mailto:ian.campbell@citrix.com]
> > Sent: Monday, June 08, 2015 6:31 PM
> > To: Pang, LongtaoX
> > Cc: xen-devel@lists.xen.org; Ian.Jackson@eu.citrix.com; wei.liu2@citrix.com; Hu,
> > Robert
> > Subject: Re: [OSSTEST Nested PATCH v11 4/7] Changes on test step of Debian hvm
> > guest install
> > 
> > On Tue, 2015-05-26 at 17:08 +0800, longtao.pang wrote:
> > > 1. The default disk size for guest is '10000M' which is not sufficient
> > > for nested HVM guest, using larger disk size for nested guest
> > > to accommodate to nested test requirement, the specific disk_size is
> > > defined by make-flight.
> > > 2. In L1 installation context, assign more memory (defined in runvar) to
> > > it; Since it acts as a nested hypervisor anyway.
> > > 3. Comment out CDROM entry in sources.list to make HTTP URL entry
> > > available for L1 hvm guest.
> > > 4. Enable nestedhvm feature in 'ExtraConfig' for nested job.
> > >
> > > Signed-off-by: longtao.pang <longtaox.pang@intel.com>
> > 
> > Acked-by: Ian Campbell <ian.campbell@citrix.com>
> > 
> > One query:
> > [...]
> > > @@ -174,13 +185,18 @@ sub prep () {
> > >      if ($host_freemem_mb > $ram_lots * 2 + $ram_minslop) {
> > >          $ram_mb = $ram_lots;
> > >      } else {
> > > -        $ram_mb = 768;
> > > +        # Use guest_var to get specific memsize, or will use default '768'
> > > +        $ram_mb= guest_var($gho,'memsize',768);
> > 
> > I think this only happens if the host has less than "$ram_lots * 2 +
> > $ram_minslop" (==10100M) free, otherwise you get $ram_lots (5000M),
> > which might be less than the runvar asked for...
> > 
> For nested job, the specific 'memsize' for L1 guest is 3072M which is defined by make-flight.
> If the "$ram_lots" equal to 5000M which is larger than 3072M, that's suitable for nested L1 guest.
> The condition for nested L1 guest's memory size that should not be less than 3072M, that's why we 
> add the code of "$ram_mb =guest_var($gho,'memsize',768)" here.

I was talking about the general case, which is broken for any guest
configured to have RAM > $ram_lots.


> > Perhaps what we really want (maybe in a followup patch is):
> > 
> >         $ram_mb = guest_var($gho,'memsize',undef);
> >         if (!$ram_mb) {
> >              if ($host_freemem_mb > $ram_lots * 2 + $ram_minslop) {
> >                   $ram_mb = $ram_lots;
> >              } else {
> >                   $ram_mb = 768;
> >              }
> >         }
> > ?
> > 
> So, I think maybe it's no need to change that.
> Please correct me, if I am wrong.