From: Gerd Hoffmann <kraxel@redhat.com>
To: "Gabriel L. Somlo" <gsomlo@gmail.com>
Cc: peter.maydell@linaro.org, "Gabriel L. Somlo" <somlo@cmu.edu>,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 1/2] fw_cfg: add fw_cfg_modify_i16 (update) method
Date: Tue, 09 Jun 2015 10:14:21 +0200 [thread overview]
Message-ID: <1433837661.26677.1.camel@redhat.com> (raw)
In-Reply-To: <20150608182630.GH32650@HEDWIG.INI.CMU.EDU>
On Mo, 2015-06-08 at 14:26 -0400, Gabriel L. Somlo wrote:
> On Mon, Jun 08, 2015 at 02:10:44PM -0400, Gabriel L. Somlo wrote:
> > Allow the ability to modify the value of an existing 16-bit integer
> > fw_cfg item.
> >
> > Signed-off-by: Gabriel Somlo <somlo@cmu.edu>
> > ---
> >
> > Couple of thoughts:
> >
> > 1. I'm thinking about pre-emptively creating _i16, _i32, and _i64
> > versions, but right now (for fixing sparc and ppc) we only need
> > the _i16 version. What to do ?
>
> Presumably, I'll update the documentation to mention these update
> functions as well (one more reason to do all three versions rather
> than just _i16) :)
Should be easy to add this once they are actually needed.
Documentation update is fine, can go incremental though.
cheers,
Gerd
next prev parent reply other threads:[~2015-06-09 8:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-08 18:10 [Qemu-devel] [PATCH 0/2] fw_cfg: *prequel* to cleanup series Gabriel L. Somlo
2015-06-08 18:10 ` [Qemu-devel] [PATCH 1/2] fw_cfg: add fw_cfg_modify_i16 (update) method Gabriel L. Somlo
2015-06-08 18:26 ` Gabriel L. Somlo
2015-06-09 8:14 ` Gerd Hoffmann [this message]
2015-06-08 18:10 ` [Qemu-devel] [PATCH 2/2] fw_cfg: fix FW_CFG_BOOT_DEVICE update on ppc and sparc Gabriel L. Somlo
2015-06-09 8:15 ` [Qemu-devel] [PATCH 0/2] fw_cfg: *prequel* to cleanup series Gerd Hoffmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1433837661.26677.1.camel@redhat.com \
--to=kraxel@redhat.com \
--cc=gsomlo@gmail.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=somlo@cmu.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.