From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <ian.campbell@citrix.com>
Subject: Re: [PATCH OSSTEST v2] Stubdom test case
Date: Tue, 9 Jun 2015 11:36:35 +0100
Message-ID: <1433846195.7108.536.camel@citrix.com>
References: <1433793268-2910-1-git-send-email-wei.liu2@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta3.messagelabs.com ([195.245.230.39])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <prvs=595170134=Ian.Campbell@citrix.com>)
	id 1Z2Gtc-0004Bo-3q
	for xen-devel@lists.xenproject.org; Tue, 09 Jun 2015 10:36:40 +0000
In-Reply-To: <1433793268-2910-1-git-send-email-wei.liu2@citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Wei Liu <wei.liu2@citrix.com>
Cc: Xen-devel <xen-devel@lists.xenproject.org>, ian.jackson@eu.citrix.com
List-Id: xen-devel@lists.xenproject.org

On Mon, 2015-06-08 at 20:54 +0100, Wei Liu wrote:
> Currently only QEMU traditional supports stubdom, so we only create
> 
> test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64
> test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm
> test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64
> test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm
> 
> Note that stubdom only supports serial='pty'. Piping serial to stderr
> causes stubdom to exit abnormally.
> 
> Signed-off-by: Wei Liu <wei.liu2@citrix.com>
> ---
> Changes in v2:
> 1. Don't set stubdom runvar for every test case.

>>From the list of runvars I don't think this happened correctly:

> +xen-unstable               test-amd64-amd64-xl-qemut-debianhvm-amd64             enable_stubdom              false
> +xen-unstable               test-amd64-amd64-xl-qemut-debianhvm-amd64-xsm         enable_stubdom              false

etc etc

Also:

> +xen-unstable               test-amd64-amd64-xl-qemuu-debianhvm-amd64             enable_stubdom
> +xen-unstable               test-amd64-amd64-xl-qemuu-debianhvm-amd64-xsm         enable_stubdom
> +xen-unstable               test-amd64-amd64-xl-qemuu-ovmf-amd64                  enable_stubdom

I don't think is desired.

> +  stubdom_suffix="";
> +  if [ x$stubdom = xtrue ]; then
> +      stubdom_suffix="-stubdom"
> +  fi
> +
> +  job_create_test test-$xenarch$kern-$dom0arch-xl$qemuu_suffix$stubdom_suffix-$testname-amd64\
>      test-debianhvm xl $xenarch $dom0arch $qemuu_runvar \
>      enable_xsm=$xsm                             \
> +    enable_stubdom=$stubdom                     \

if [ x$stubdom != x ] ; then
        stubdom_runvar="enable_stubdom=$stubdom"
fi

Then just pass $stubdom_runvar to job_create_test, this arranges that
enable_stubdom is only set if a specific value is requested.

> +      for stubdom in true false ; do

for stubdom in true '' ; do

then arranges to pass the right things into the above. May need more or
less quoting when $stubdom is used now.

Ian.