From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <ian.campbell@citrix.com>
Subject: Re: [PATCH v4] efi: Avoid calling boot services after
 ExitBootServices()
Date: Tue, 9 Jun 2015 14:44:53 +0100
Message-ID: <1433857493.7108.557.camel@citrix.com>
References: <1433237923-14591-1-git-send-email-ross.lagerwall@citrix.com>
	<5576C1BD.9020609@citrix.com>
	<5576EF6C020000780008294A@mail.emea.novell.com>
	<1433854382.7108.554.camel@citrix.com> <5576E4AC.1000403@citrix.com>
	<1433856249.7108.555.camel@citrix.com> <5576E96F.1070809@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <5576E96F.1070809@citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: Keir Fraser <keir@xen.org>, Tim Deegan <tim@xen.org>, xen-devel@lists.xen.org, Ross Lagerwall <ross.lagerwall@citrix.com>, Stefano Stabellini <stefano.stabellini@citrix.com>, Jan Beulich <JBeulich@suse.com>
List-Id: xen-devel@lists.xenproject.org

On Tue, 2015-06-09 at 14:26 +0100, Andrew Cooper wrote:
> On 09/06/15 14:24, Ian Campbell wrote:
> > On Tue, 2015-06-09 at 14:05 +0100, Ross Lagerwall wrote:
> >> On 06/09/2015 01:53 PM, Ian Campbell wrote:
> >>> In terms of the rest of the patch, are those two places changed to use
> >>> SystemTable->BootServices instead of efi_bs, if the point of the patch
> >>> is to not use BootServices after exit is called?
> >>>
> >> GetMemoryMap() and ExitBootServices() are the only functions explicitly 
> >> allowed after the first call to ExitBootServices() so they are called 
> >> via SystemTable->BootServices. efi_bs is set to NULL to ensure that no 
> >> other bootservices are called.
> > I see. That might be worth a mention in the commit log?
> 
> The commit message does say this.  Is there anything you think needs
> further clarification?

It says just:
        After the first call to ExitBootServices(), avoid calling any
        boot
        services by setting setting efi_bs to NULL and halting in
        blexit().

No mention of the fact that GetMemoryMap() and ExitBootServices() are
not covered by the blanket statement regarding boot services.

Ian.