From: Richard Weinberger <richard@nod.at>
To: Jan Kiszka <jan.kiszka@siemens.com>
Cc: Florian Bezdeka <florian.bezdeka@siemens.com>,
xenomai <xenomai@xenomai.org>
Subject: Re: [PATCH] xnthread_relax: Make sure wakework irq work has a stack
Date: Tue, 5 Apr 2022 17:53:20 +0200 (CEST) [thread overview]
Message-ID: <1433861802.219536.1649174000463.JavaMail.zimbra@nod.at> (raw)
In-Reply-To: <54aa3260-9a9b-dbdb-90a8-6395fd86fc28@siemens.com>
----- Ursprüngliche Mail -----
> Von: "Jan Kiszka" <jan.kiszka@siemens.com>
> I would like to have an explanation or prove points (traces, assertions)
> that we actually see xnthread_relax overtaking the delivery of its own
> wakework.
I can re-test with something like that:
diff --git a/kernel/cobalt/thread.c b/kernel/cobalt/thread.c
index beda67e18..4c100b645 100644
--- a/kernel/cobalt/thread.c
+++ b/kernel/cobalt/thread.c
@@ -2159,6 +2159,7 @@ void xnthread_relax(int notify, int reason)
pipeline_clear_mayday();
trace_cobalt_shadow_relaxed(thread);
+ WARN_ON_ONCE(irq_work_is_busy(&wakework.inband_work.work));
}
EXPORT_SYMBOL_GPL(xnthread_relax);
But I fear this might take some time. The KASAM spat happened only once
and also only after the test ran for almost 5 days.
Thanks,
//richard
next prev parent reply other threads:[~2022-04-05 15:53 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-05 11:40 [PATCH] xnthread_relax: Make sure wakework irq work has a stack Richard Weinberger
2022-04-05 13:01 ` Bezdeka, Florian
2022-04-05 13:10 ` Richard Weinberger
2022-04-05 15:38 ` Jan Kiszka
2022-04-05 15:53 ` Richard Weinberger [this message]
2022-04-05 16:01 ` Jan Kiszka
2022-04-05 16:14 ` Richard Weinberger
2022-04-05 17:23 ` Richard Weinberger
2022-04-05 17:39 ` Jan Kiszka
2022-04-05 16:59 ` Philippe Gerum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1433861802.219536.1649174000463.JavaMail.zimbra@nod.at \
--to=richard@nod.at \
--cc=florian.bezdeka@siemens.com \
--cc=jan.kiszka@siemens.com \
--cc=xenomai@xenomai.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.