From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com ([134.134.136.65]:2887 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753374AbbFIQpk (ORCPT ); Tue, 9 Jun 2015 12:45:40 -0400 From: "Jiang, Dave" To: "bhelgaas@google.com" CC: "Allen.Hubbe@emc.com" , "linux-kernel@vger.kernel.org" , "linux-pci@vger.kernel.org" , "jdmason@kudzu.us" , "linux-ntb@googlegroups.com" Subject: Re: [PATCH v3 18/18] NTB: Increase transport MTU to 64k from 16k Date: Tue, 9 Jun 2015 16:45:36 +0000 Message-ID: <1433868335.38406.111.camel@intel.com> References: In-Reply-To: Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Sender: linux-pci-owner@vger.kernel.org List-ID: T24gVHVlLCAyMDE1LTA2LTA5IGF0IDExOjA0IC0wNTAwLCAnQmpvcm4gSGVsZ2FhcycgdmlhIGxp bnV4LW50YiB3cm90ZToNCj4gT24gVHVlLCBKdW4gOSwgMjAxNSBhdCA0OjQ0IEFNLCBBbGxlbiBI dWJiZSA8QWxsZW4uSHViYmVAZW1jLmNvbT4gDQo+IHdyb3RlOg0KPiA+IEZyb206IERhdmUgSmlh bmcgPGRhdmUuamlhbmdAaW50ZWwuY29tPg0KPiA+IA0KPiA+IEJlbmNobWFya2luZyBzaG93ZWQg c2lnbmlmaWNhbnQgcGVyZm9ybWFuY2UgaW5jcmVhc2UgZ29pbmcgZnJvbSBNVFUgDQo+ID4gc2l6 ZQ0KPiA+IG9mIDY0ayBmcm9tIDE2ay4gIENoYW5naW5nIHRoZSBkZWZhdWx0Lg0KPiANCj4gVGhp cyBjaGFuZ2Vsb2cgZG9lc24ndCBwYXJzZS4gIEkgdGhpbmsgeW91IG1lYW4gImdvaW5nIGZyb20g TVRVIHNpemUNCj4gMTZrIHRvIDY0ay4iDQoNClllcy4gU29ycnkgYWJvdXQgdGhlIGNvbmZ1c2lv bi4NCg0KPiANCj4gVGhlIG9yaWdpbmFsIHZhbHVlIHdhcyAweDQwMWUgKDE2ayArIDB4MWUpLCBh bmQgdGhlIG5ldyB2YWx1ZSBpcw0KPiBleGFjdGx5IDY0ay4gIFBsZWFzZSBpbmNsdWRlIGEgbm90 ZSBhYm91dCB3aGF0IHRoYXQgZXh0cmEgMHgxZSB3YXMgDQo+IGZvcg0KPiBhbmQgd2h5IGl0IGlz bid0IG5lZWRlZCBpbiB0aGUgbmV3IHZhbHVlLg0KDQpKb24sIGNhbiB5b3UgY29tbWVudCBvbiB3 aHkgdGhlcmUncyB0aGUgYWRkaXRpb25hbCAzMCBieXRlcyBvbiB0b3Agb2YNCjE2ayBpbiB0aGUg cHJldmlvdXMgdmFsdWU/IA0KDQo+IA0KPiA+IFNpZ25lZC1vZmYtYnk6IERhdmUgSmlhbmcgPGRh dmUuamlhbmdAaW50ZWwuY29tPg0KPiA+IC0tLQ0KPiA+ICBkcml2ZXJzL250Yi9udGJfdHJhbnNw b3J0LmMgfCAyICstDQo+ID4gIDEgZmlsZSBjaGFuZ2VkLCAxIGluc2VydGlvbigrKSwgMSBkZWxl dGlvbigtKQ0KPiA+IA0KPiA+IGRpZmYgLS1naXQgYS9kcml2ZXJzL250Yi9udGJfdHJhbnNwb3J0 LmMgDQo+ID4gYi9kcml2ZXJzL250Yi9udGJfdHJhbnNwb3J0LmMNCj4gPiBpbmRleCBlYTIzN2Fl Y2EyOGMuLmM4N2JjMGNiZDYwNyAxMDA2NDQNCj4gPiAtLS0gYS9kcml2ZXJzL250Yi9udGJfdHJh bnNwb3J0LmMNCj4gPiArKysgYi9kcml2ZXJzL250Yi9udGJfdHJhbnNwb3J0LmMNCj4gPiBAQCAt NzYsNyArNzYsNyBAQCBzdGF0aWMgdW5zaWduZWQgbG9uZyBtYXhfbXdfc2l6ZTsNCj4gPiAgbW9k dWxlX3BhcmFtKG1heF9td19zaXplLCB1bG9uZywgMDY0NCk7DQo+ID4gIE1PRFVMRV9QQVJNX0RF U0MobWF4X213X3NpemUsICJMaW1pdCBzaXplIG9mIGxhcmdlIG1lbW9yeSANCj4gPiB3aW5kb3dz Iik7DQo+ID4gDQo+ID4gLXN0YXRpYyB1bnNpZ25lZCBpbnQgdHJhbnNwb3J0X210dSA9IDB4NDAx RTsNCj4gPiArc3RhdGljIHVuc2lnbmVkIGludCB0cmFuc3BvcnRfbXR1ID0gMHgxMDAwMDsNCj4g PiAgbW9kdWxlX3BhcmFtKHRyYW5zcG9ydF9tdHUsIHVpbnQsIDA2NDQpOw0KPiA+ICBNT0RVTEVf UEFSTV9ERVNDKHRyYW5zcG9ydF9tdHUsICJNYXhpbXVtIHNpemUgb2YgTlRCIHRyYW5zcG9ydCAN Cj4gPiBwYWNrZXRzIik7DQo+ID4gDQo+ID4gLS0NCj4gPiAyLjQuMC5yYzAuNDMuZ2NmOGE4YzYN Cj4gPiANCj4gPiAtLQ0KPiA+IFRvIHVuc3Vic2NyaWJlIGZyb20gdGhpcyBsaXN0OiBzZW5kIHRo ZSBsaW5lICJ1bnN1YnNjcmliZSBsaW51eA0KPiA+IC1wY2kiIGluDQo+ID4gdGhlIGJvZHkgb2Yg YSBtZXNzYWdlIHRvIG1ham9yZG9tb0B2Z2VyLmtlcm5lbC5vcmcNCj4gPiBNb3JlIG1ham9yZG9t byBpbmZvIGF0ICBodHRwOi8vdmdlci5rZXJuZWwub3JnL21ham9yZG9tby1pbmZvLmh0bWwNCj4g From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com. [134.134.136.65]) by gmr-mx.google.com with ESMTP id xz5si729032pac.1.2015.06.09.09.45.39 for ; Tue, 09 Jun 2015 09:45:39 -0700 (PDT) From: "Jiang, Dave" Subject: Re: [PATCH v3 18/18] NTB: Increase transport MTU to 64k from 16k Date: Tue, 9 Jun 2015 16:45:36 +0000 Message-ID: <1433868335.38406.111.camel@intel.com> References: In-Reply-To: Content-Language: en-US Content-Type: text/plain; charset="utf-8" Content-ID: <7DCF224B447D9A4AB84DFC0FF2BD3E76@intel.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 Return-Path: dave.jiang@intel.com To: "bhelgaas@google.com" Cc: "Allen.Hubbe@emc.com" , "linux-kernel@vger.kernel.org" , "linux-pci@vger.kernel.org" , "jdmason@kudzu.us" , "linux-ntb@googlegroups.com" List-ID: T24gVHVlLCAyMDE1LTA2LTA5IGF0IDExOjA0IC0wNTAwLCAnQmpvcm4gSGVsZ2FhcycgdmlhIGxp bnV4LW50YiB3cm90ZToNCj4gT24gVHVlLCBKdW4gOSwgMjAxNSBhdCA0OjQ0IEFNLCBBbGxlbiBI dWJiZSA8QWxsZW4uSHViYmVAZW1jLmNvbT4gDQo+IHdyb3RlOg0KPiA+IEZyb206IERhdmUgSmlh bmcgPGRhdmUuamlhbmdAaW50ZWwuY29tPg0KPiA+IA0KPiA+IEJlbmNobWFya2luZyBzaG93ZWQg c2lnbmlmaWNhbnQgcGVyZm9ybWFuY2UgaW5jcmVhc2UgZ29pbmcgZnJvbSBNVFUgDQo+ID4gc2l6 ZQ0KPiA+IG9mIDY0ayBmcm9tIDE2ay4gIENoYW5naW5nIHRoZSBkZWZhdWx0Lg0KPiANCj4gVGhp cyBjaGFuZ2Vsb2cgZG9lc24ndCBwYXJzZS4gIEkgdGhpbmsgeW91IG1lYW4gImdvaW5nIGZyb20g TVRVIHNpemUNCj4gMTZrIHRvIDY0ay4iDQoNClllcy4gU29ycnkgYWJvdXQgdGhlIGNvbmZ1c2lv bi4NCg0KPiANCj4gVGhlIG9yaWdpbmFsIHZhbHVlIHdhcyAweDQwMWUgKDE2ayArIDB4MWUpLCBh bmQgdGhlIG5ldyB2YWx1ZSBpcw0KPiBleGFjdGx5IDY0ay4gIFBsZWFzZSBpbmNsdWRlIGEgbm90 ZSBhYm91dCB3aGF0IHRoYXQgZXh0cmEgMHgxZSB3YXMgDQo+IGZvcg0KPiBhbmQgd2h5IGl0IGlz bid0IG5lZWRlZCBpbiB0aGUgbmV3IHZhbHVlLg0KDQpKb24sIGNhbiB5b3UgY29tbWVudCBvbiB3 aHkgdGhlcmUncyB0aGUgYWRkaXRpb25hbCAzMCBieXRlcyBvbiB0b3Agb2YNCjE2ayBpbiB0aGUg cHJldmlvdXMgdmFsdWU/IA0KDQo+IA0KPiA+IFNpZ25lZC1vZmYtYnk6IERhdmUgSmlhbmcgPGRh dmUuamlhbmdAaW50ZWwuY29tPg0KPiA+IC0tLQ0KPiA+ICBkcml2ZXJzL250Yi9udGJfdHJhbnNw b3J0LmMgfCAyICstDQo+ID4gIDEgZmlsZSBjaGFuZ2VkLCAxIGluc2VydGlvbigrKSwgMSBkZWxl dGlvbigtKQ0KPiA+IA0KPiA+IGRpZmYgLS1naXQgYS9kcml2ZXJzL250Yi9udGJfdHJhbnNwb3J0 LmMgDQo+ID4gYi9kcml2ZXJzL250Yi9udGJfdHJhbnNwb3J0LmMNCj4gPiBpbmRleCBlYTIzN2Fl Y2EyOGMuLmM4N2JjMGNiZDYwNyAxMDA2NDQNCj4gPiAtLS0gYS9kcml2ZXJzL250Yi9udGJfdHJh bnNwb3J0LmMNCj4gPiArKysgYi9kcml2ZXJzL250Yi9udGJfdHJhbnNwb3J0LmMNCj4gPiBAQCAt NzYsNyArNzYsNyBAQCBzdGF0aWMgdW5zaWduZWQgbG9uZyBtYXhfbXdfc2l6ZTsNCj4gPiAgbW9k dWxlX3BhcmFtKG1heF9td19zaXplLCB1bG9uZywgMDY0NCk7DQo+ID4gIE1PRFVMRV9QQVJNX0RF U0MobWF4X213X3NpemUsICJMaW1pdCBzaXplIG9mIGxhcmdlIG1lbW9yeSANCj4gPiB3aW5kb3dz Iik7DQo+ID4gDQo+ID4gLXN0YXRpYyB1bnNpZ25lZCBpbnQgdHJhbnNwb3J0X210dSA9IDB4NDAx RTsNCj4gPiArc3RhdGljIHVuc2lnbmVkIGludCB0cmFuc3BvcnRfbXR1ID0gMHgxMDAwMDsNCj4g PiAgbW9kdWxlX3BhcmFtKHRyYW5zcG9ydF9tdHUsIHVpbnQsIDA2NDQpOw0KPiA+ICBNT0RVTEVf UEFSTV9ERVNDKHRyYW5zcG9ydF9tdHUsICJNYXhpbXVtIHNpemUgb2YgTlRCIHRyYW5zcG9ydCAN Cj4gPiBwYWNrZXRzIik7DQo+ID4gDQo+ID4gLS0NCj4gPiAyLjQuMC5yYzAuNDMuZ2NmOGE4YzYN Cj4gPiANCj4gPiAtLQ0KPiA+IFRvIHVuc3Vic2NyaWJlIGZyb20gdGhpcyBsaXN0OiBzZW5kIHRo ZSBsaW5lICJ1bnN1YnNjcmliZSBsaW51eA0KPiA+IC1wY2kiIGluDQo+ID4gdGhlIGJvZHkgb2Yg YSBtZXNzYWdlIHRvIG1ham9yZG9tb0B2Z2VyLmtlcm5lbC5vcmcNCj4gPiBNb3JlIG1ham9yZG9t byBpbmZvIGF0ICBodHRwOi8vdmdlci5rZXJuZWwub3JnL21ham9yZG9tby1pbmZvLmh0bWwNCj4g From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933078AbbFIQpt (ORCPT ); Tue, 9 Jun 2015 12:45:49 -0400 Received: from mga03.intel.com ([134.134.136.65]:2887 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753374AbbFIQpk (ORCPT ); Tue, 9 Jun 2015 12:45:40 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.13,582,1427785200"; d="scan'208";a="740222259" From: "Jiang, Dave" To: "bhelgaas@google.com" CC: "Allen.Hubbe@emc.com" , "linux-kernel@vger.kernel.org" , "linux-pci@vger.kernel.org" , "jdmason@kudzu.us" , "linux-ntb@googlegroups.com" Subject: Re: [PATCH v3 18/18] NTB: Increase transport MTU to 64k from 16k Thread-Topic: [PATCH v3 18/18] NTB: Increase transport MTU to 64k from 16k Thread-Index: AQHQosN14y56flQ9jkSLEoBalfVfxJ2ky9QAgAALZ4A= Date: Tue, 9 Jun 2015 16:45:36 +0000 Message-ID: <1433868335.38406.111.camel@intel.com> References: In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [143.182.51.82] Content-Type: text/plain; charset="utf-8" Content-ID: <7DCF224B447D9A4AB84DFC0FF2BD3E76@intel.com> MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by nfs id t59Gjrc2029895 On Tue, 2015-06-09 at 11:04 -0500, 'Bjorn Helgaas' via linux-ntb wrote: > On Tue, Jun 9, 2015 at 4:44 AM, Allen Hubbe > wrote: > > From: Dave Jiang > > > > Benchmarking showed significant performance increase going from MTU > > size > > of 64k from 16k. Changing the default. > > This changelog doesn't parse. I think you mean "going from MTU size > 16k to 64k." Yes. Sorry about the confusion. > > The original value was 0x401e (16k + 0x1e), and the new value is > exactly 64k. Please include a note about what that extra 0x1e was > for > and why it isn't needed in the new value. Jon, can you comment on why there's the additional 30 bytes on top of 16k in the previous value? > > > Signed-off-by: Dave Jiang > > --- > > drivers/ntb/ntb_transport.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/ntb/ntb_transport.c > > b/drivers/ntb/ntb_transport.c > > index ea237aeca28c..c87bc0cbd607 100644 > > --- a/drivers/ntb/ntb_transport.c > > +++ b/drivers/ntb/ntb_transport.c > > @@ -76,7 +76,7 @@ static unsigned long max_mw_size; > > module_param(max_mw_size, ulong, 0644); > > MODULE_PARM_DESC(max_mw_size, "Limit size of large memory > > windows"); > > > > -static unsigned int transport_mtu = 0x401E; > > +static unsigned int transport_mtu = 0x10000; > > module_param(transport_mtu, uint, 0644); > > MODULE_PARM_DESC(transport_mtu, "Maximum size of NTB transport > > packets"); > > > > -- > > 2.4.0.rc0.43.gcf8a8c6 > > > > -- > > To unsubscribe from this list: send the line "unsubscribe linux > > -pci" in > > the body of a message to majordomo@vger.kernel.org > > More majordomo info at http://vger.kernel.org/majordomo-info.html > {.n++%ݶw{.n+{G{ayʇڙ,jfhz_(階ݢj"mG?&~iOzv^m ?I