From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <ian.campbell@citrix.com>
Subject: Re: [PATCH 2/4] EFI/early: add /mapbs to map
 EfiBootServices{Code, Data}
Date: Wed, 10 Jun 2015 10:26:04 +0100
Message-ID: <1433928364.30003.21.camel@citrix.com>
References: <55770B190200007800082A2C@mail.emea.novell.com>
	<55770BDF0200007800082A43@mail.emea.novell.com>
	<1433926580.30003.4.camel@citrix.com>
	<55781C570200007800082F01@mail.emea.novell.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta14.messagelabs.com ([193.109.254.103])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <prvs=596f3e333=Ian.Campbell@citrix.com>)
	id 1Z2cIT-0005TF-Ia
	for xen-devel@lists.xenproject.org; Wed, 10 Jun 2015 09:27:45 +0000
In-Reply-To: <55781C570200007800082F01@mail.emea.novell.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Jan Beulich <JBeulich@suse.com>
Cc: roy.franz@linaro.org, xen-devel <xen-devel@lists.xenproject.org>
List-Id: xen-devel@lists.xenproject.org

On Wed, 2015-06-10 at 10:15 +0100, Jan Beulich wrote:
> >>> On 10.06.15 at 10:56, <ian.campbell@citrix.com> wrote:
> > On Tue, 2015-06-09 at 14:53 +0100, Jan Beulich wrote:
> >> From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
> >> 
> >> To help on certain platforms to run.
> >> 
> >> Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
> >> Signed-off-by: Jan Beulich <jbeulich@suse.com>
> > 
> > To be effective (or at least consistent) on ARM, would we also want to
> > change its efi_process_memory_map_bootinfo:
> >         if ( desc_ptr->Type == EfiConventionalMemory
> >              || desc_ptr->Type == EfiBootServicesCode
> >              || desc_ptr->Type == EfiBootServicesData )
> > to include a check on map_bs?
> 
> I'm not convinced, but I also don't know the history of why boot
> services areas are being included here in the first place - Roy?
> I.e. if the checks weren't there already, I'd agree that an addition
> similar to the other ones would be needed here, but with the x86
> side getting relaxed I don't see why you would want to tighten the
> ARM side at the same time.

I read it backwards and thought this was currently excluding them like
x86 does.

Am I correct that the stricter x86 behaviour is per the spec, and this
new option is a workaround for non-compliant systems?

If so unless Roy knows of a reason why these should be mapped on ARM be
default (i.e. the ARM spec differs) I'd be inclined to suggesting the
default be stricter on ARM too for consistency.

Ian.