From: Johannes Berg <johannes@sipsolutions.net>
To: agreen@cococorp.com
Cc: linux-wireless@vger.kernel.org, Jesse Jones <jjones@cococorp.com>
Subject: Re: [PATCH v2] mac80211: Fix a case of incorrect metric used when forwarding a PREQ
Date: Wed, 10 Jun 2015 11:54:08 +0200 [thread overview]
Message-ID: <1433930048.3145.0.camel@sipsolutions.net> (raw)
In-Reply-To: <557774B8.6000702@cococorp.com> (sfid-20150610_012050_857822_799081EF)
On Tue, 2015-06-09 at 16:20 -0700, Alexis Green wrote:
> This patch fixes a bug in hwmp_preq_frame_process where the wrong metric
> can be used when forwarding a PREQ. This happens because the code uses
> the same metric variable to record the value of the metric to the source
> of the PREQ and the value of the metric to the target of the PREQ.
>
> This comes into play when both reply and forward are set which happens
> when IEEE80211_PREQ_PROACTIVE_PREP_FLAG is set and when MP_F_DO | MP_F_RF
> is set. The original code had a special case to handle the first case
> but not the second.
>
> The patch uses distinct variables for the two metrics which makes the
> code flow much clearer and removes the need to restore the original
> value of metric when forwarding.
Applied, thanks.
johannes
prev parent reply other threads:[~2015-06-10 9:54 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-09 23:20 [PATCH v2] mac80211: Fix a case of incorrect metric used when forwarding a PREQ Alexis Green
2015-06-10 9:54 ` Johannes Berg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1433930048.3145.0.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=agreen@cococorp.com \
--cc=jjones@cococorp.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.