From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH V6 04/10] xen/arm: Use cpumask_t type for vcpu_mask in vgic_to_sgi Date: Wed, 10 Jun 2015 11:27:26 +0100 Message-ID: <1433932046.30003.27.camel@citrix.com> References: <1433163388-16970-1-git-send-email-cbz@baozis.org> <1433163388-16970-5-git-send-email-cbz@baozis.org> <1433520329.7108.334.camel@citrix.com> <20150610102105.GA3982@cbz-thinkpad> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1Z2dFB-0003Nw-HE for xen-devel@lists.xenproject.org; Wed, 10 Jun 2015 10:28:25 +0000 In-Reply-To: <20150610102105.GA3982@cbz-thinkpad> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Chen Baozi Cc: Julien Grall , xen-devel@lists.xenproject.org List-Id: xen-devel@lists.xenproject.org On Wed, 2015-06-10 at 18:21 +0800, Chen Baozi wrote: > > Perhaps we want to bite the bullet now and change the vgic_to_sgi to > > take an affinity path thing (aff3.aff2.aff1) + target list, instead of a > > cpumask? That makes sense given the 16 CPU per AFF0 limitation, since > > there is only a limited set of cpumask patterns which can be specified, > > so we don't need the fully arbitrary bitmap. > > It seems that only GICv3 supports affinity level. And vgic_to_sgi is shared > by both vGICv2 and vGICv3... However, we can make aff3==aff2==aff1==0 and put > the 8-bit GICv2 cpumask in the target list. If this is good for vGICv2, I > have no problem on it. I think that makes sense, we can have gicv2 assert that aff3..1 == 0 (or the corresponding argument which encodes them all). The alternative would be to refactor somehow such that the generic interface was suitable for both and the difference becomes internal. Ian.