diff for duplicates of <1433955045.20602.2.camel@intel.com> diff --git a/a/1.txt b/N1/1.txt index 65d0170..d4160a2 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,28 +1,37 @@ -T24gV2VkLCAyMDE1LTA2LTEwIGF0IDEyOjMzIC0wNDAwLCBOaWNob2xhcyBLcmF1c2Ugd3JvdGU6 -DQo+IFRoaXMgbWFrZXMgdGhlIGZ1bmN0aW9uIGl3bF9yZXN1bWVfc3RhdHVzX2ZuIHJldHVybiBm -YWxzZSBub3cgaWYNCj4gdGhlIHJlY2VpdmVkIHBhY2tldCBvZiB0eXBlIGl3bF9yeF9wYWNrZXQg -aXMgbm90IHRoZSBzYW1lIHNpemUNCj4gYXMgdGhlIHN0cnVjdHVyZSBwb2ludGVyLCBpd2xfcmVz -dW1lX2RhdGEncyBjbWQgZWxlbWVudCBpbiBvcmRlcg0KPiB0byBzaWduYWwgY2FsbGVycyBhYm91 -dCB0aGlzIGVycm9yIGFuZCBhbGxvdyB0aGVtIHRvIGhhbmRsZSBpdA0KPiBvY2N1cnJlbnRseS4N -Cj4gDQoNCkhtLi4uIERpZCB5b3UgYWN0dWFsbHkgaGl0IHRoaXMgaWY/DQpJIGFtIG5vdCBzdXJl -IEkgcmVhbGx5IHdhbnQgdG8gd2FpdCBoZXJlICh3aGljaCBpcyB3aGF0IHdpbGwgaGFwcGVuIGlm -DQp5b3UgcmV0dXJuIGZhbHNlKSB3aGVuIHdlIGdldCBhbiB1bmV4cGVjdGVkIGxlbmd0aD8gSSBk -byBub3QgZXhwZWN0DQphbnl0aGluZyBiZXNpZGVzIHRoZSByZXNwb25zZSBJIGFtIHdhaXRpbmcg -Zm9yIHNpbmNlIHRoZSBmaXJtd2FyZSBpcw0KaGFuZGxpbmcgdGhlIEdFVF9TVEFUVVMgKm9ubHkq -IC0gaXQganVzdCBjYW1lIGJhY2sgZnJvbSBXb1dMQU4uIEJvdHRvbQ0KbGluZSwgdGhpcyBpcyBy -ZWFsbHkgYW4gZXJyb3IgcGF0aCBhbmQgSSBwcmVmZXIgdG8gZXhpdCBhbmQgbm90IHdhaXQgZm9y -DQp0aGUgdGltZW91dCBpbiB0aGF0IGNhc2UuDQpCdXQgSSBtaWdodCBiZSBtaXNzaW5nIHNvbWV0 -aGluZz8NCg0KPiBTaWduZWQtb2ZmLWJ5OiBOaWNob2xhcyBLcmF1c2UgPHhlcm9mb2lmeUBnbWFp -bC5jb20+DQo+IC0tLQ0KPiAgZHJpdmVycy9uZXQvd2lyZWxlc3MvaXdsd2lmaS9kdm0vbWFjODAy -MTEuYyB8IDIgKy0NCj4gIDEgZmlsZSBjaGFuZ2VkLCAxIGluc2VydGlvbigrKSwgMSBkZWxldGlv -bigtKQ0KPiANCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvbmV0L3dpcmVsZXNzL2l3bHdpZmkvZHZt -L21hYzgwMjExLmMgYi9kcml2ZXJzL25ldC93aXJlbGVzcy9pd2x3aWZpL2R2bS9tYWM4MDIxMS5j -DQo+IGluZGV4IDVhYmQ2MmUuLjIxZTgwOGMgMTAwNjQ0DQo+IC0tLSBhL2RyaXZlcnMvbmV0L3dp -cmVsZXNzL2l3bHdpZmkvZHZtL21hYzgwMjExLmMNCj4gKysrIGIvZHJpdmVycy9uZXQvd2lyZWxl -c3MvaXdsd2lmaS9kdm0vbWFjODAyMTEuYw0KPiBAQCAtNDA5LDcgKzQwOSw3IEBAIHN0YXRpYyBi -b29sIGl3bF9yZXN1bWVfc3RhdHVzX2ZuKHN0cnVjdCBpd2xfbm90aWZfd2FpdF9kYXRhICpub3Rp -Zl93YWl0LA0KPiAgDQo+ICAJaWYgKGl3bF9yeF9wYWNrZXRfcGF5bG9hZF9sZW4ocGt0KSAhPSBz -aXplb2YoKnJlc3VtZV9kYXRhLT5jbWQpKSB7DQo+ICAJCUlXTF9FUlIocHJpdiwgInJ4IHdyb25n -IHNpemUgZGF0YVxuIik7DQo+IC0JCXJldHVybiB0cnVlOw0KPiArCQlyZXR1cm4gZmFsc2U7DQo+ -ICAJfQ0KPiAgCW1lbWNweShyZXN1bWVfZGF0YS0+Y21kLCBwa3QtPmRhdGEsIHNpemVvZigqcmVz -dW1lX2RhdGEtPmNtZCkpOw0KPiAgCXJlc3VtZV9kYXRhLT52YWxpZCA9IHRydWU7DQoNCg== +On Wed, 2015-06-10 at 12:33 -0400, Nicholas Krause wrote: +> This makes the function iwl_resume_status_fn return false now if +> the received packet of type iwl_rx_packet is not the same size +> as the structure pointer, iwl_resume_data's cmd element in order +> to signal callers about this error and allow them to handle it +> occurrently. +> + +Hm... Did you actually hit this if? +I am not sure I really want to wait here (which is what will happen if +you return false) when we get an unexpected length? I do not expect +anything besides the response I am waiting for since the firmware is +handling the GET_STATUS *only* - it just came back from WoWLAN. Bottom +line, this is really an error path and I prefer to exit and not wait for +the timeout in that case. +But I might be missing something? + +> Signed-off-by: Nicholas Krause <xerofoify@gmail.com> +> --- +> drivers/net/wireless/iwlwifi/dvm/mac80211.c | 2 +- +> 1 file changed, 1 insertion(+), 1 deletion(-) +> +> diff --git a/drivers/net/wireless/iwlwifi/dvm/mac80211.c b/drivers/net/wireless/iwlwifi/dvm/mac80211.c +> index 5abd62e..21e808c 100644 +> --- a/drivers/net/wireless/iwlwifi/dvm/mac80211.c +> +++ b/drivers/net/wireless/iwlwifi/dvm/mac80211.c +> @@ -409,7 +409,7 @@ static bool iwl_resume_status_fn(struct iwl_notif_wait_data *notif_wait, +> +> if (iwl_rx_packet_payload_len(pkt) != sizeof(*resume_data->cmd)) { +> IWL_ERR(priv, "rx wrong size data\n"); +> - return true; +> + return false; +> } +> memcpy(resume_data->cmd, pkt->data, sizeof(*resume_data->cmd)); +> resume_data->valid = true; + +ÿôèº{.nÇ+‰·Ÿ®‰†+%ŠËÿ±éݶ\x17¥Šwÿº{.nÇ+‰·¥Š{±þG«éÿŠ{ayº\x1dʇڙë,j\a¢f£¢·hšïêÿ‘êçz_è®\x03(階ŠÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?™¨èÚ&£ø§~á¶iO•æ¬z·švØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?–I¥ diff --git a/a/content_digest b/N1/content_digest index 7833a97..17f5619 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -17,33 +17,42 @@ " linux-wireless@vger.kernel.org <linux-wireless@vger.kernel.org>\0" "\00:1\0" "b\0" - "T24gV2VkLCAyMDE1LTA2LTEwIGF0IDEyOjMzIC0wNDAwLCBOaWNob2xhcyBLcmF1c2Ugd3JvdGU6\n" - "DQo+IFRoaXMgbWFrZXMgdGhlIGZ1bmN0aW9uIGl3bF9yZXN1bWVfc3RhdHVzX2ZuIHJldHVybiBm\n" - "YWxzZSBub3cgaWYNCj4gdGhlIHJlY2VpdmVkIHBhY2tldCBvZiB0eXBlIGl3bF9yeF9wYWNrZXQg\n" - "aXMgbm90IHRoZSBzYW1lIHNpemUNCj4gYXMgdGhlIHN0cnVjdHVyZSBwb2ludGVyLCBpd2xfcmVz\n" - "dW1lX2RhdGEncyBjbWQgZWxlbWVudCBpbiBvcmRlcg0KPiB0byBzaWduYWwgY2FsbGVycyBhYm91\n" - "dCB0aGlzIGVycm9yIGFuZCBhbGxvdyB0aGVtIHRvIGhhbmRsZSBpdA0KPiBvY2N1cnJlbnRseS4N\n" - "Cj4gDQoNCkhtLi4uIERpZCB5b3UgYWN0dWFsbHkgaGl0IHRoaXMgaWY/DQpJIGFtIG5vdCBzdXJl\n" - "IEkgcmVhbGx5IHdhbnQgdG8gd2FpdCBoZXJlICh3aGljaCBpcyB3aGF0IHdpbGwgaGFwcGVuIGlm\n" - "DQp5b3UgcmV0dXJuIGZhbHNlKSB3aGVuIHdlIGdldCBhbiB1bmV4cGVjdGVkIGxlbmd0aD8gSSBk\n" - "byBub3QgZXhwZWN0DQphbnl0aGluZyBiZXNpZGVzIHRoZSByZXNwb25zZSBJIGFtIHdhaXRpbmcg\n" - "Zm9yIHNpbmNlIHRoZSBmaXJtd2FyZSBpcw0KaGFuZGxpbmcgdGhlIEdFVF9TVEFUVVMgKm9ubHkq\n" - "IC0gaXQganVzdCBjYW1lIGJhY2sgZnJvbSBXb1dMQU4uIEJvdHRvbQ0KbGluZSwgdGhpcyBpcyBy\n" - "ZWFsbHkgYW4gZXJyb3IgcGF0aCBhbmQgSSBwcmVmZXIgdG8gZXhpdCBhbmQgbm90IHdhaXQgZm9y\n" - "DQp0aGUgdGltZW91dCBpbiB0aGF0IGNhc2UuDQpCdXQgSSBtaWdodCBiZSBtaXNzaW5nIHNvbWV0\n" - "aGluZz8NCg0KPiBTaWduZWQtb2ZmLWJ5OiBOaWNob2xhcyBLcmF1c2UgPHhlcm9mb2lmeUBnbWFp\n" - "bC5jb20+DQo+IC0tLQ0KPiAgZHJpdmVycy9uZXQvd2lyZWxlc3MvaXdsd2lmaS9kdm0vbWFjODAy\n" - "MTEuYyB8IDIgKy0NCj4gIDEgZmlsZSBjaGFuZ2VkLCAxIGluc2VydGlvbigrKSwgMSBkZWxldGlv\n" - "bigtKQ0KPiANCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvbmV0L3dpcmVsZXNzL2l3bHdpZmkvZHZt\n" - "L21hYzgwMjExLmMgYi9kcml2ZXJzL25ldC93aXJlbGVzcy9pd2x3aWZpL2R2bS9tYWM4MDIxMS5j\n" - "DQo+IGluZGV4IDVhYmQ2MmUuLjIxZTgwOGMgMTAwNjQ0DQo+IC0tLSBhL2RyaXZlcnMvbmV0L3dp\n" - "cmVsZXNzL2l3bHdpZmkvZHZtL21hYzgwMjExLmMNCj4gKysrIGIvZHJpdmVycy9uZXQvd2lyZWxl\n" - "c3MvaXdsd2lmaS9kdm0vbWFjODAyMTEuYw0KPiBAQCAtNDA5LDcgKzQwOSw3IEBAIHN0YXRpYyBi\n" - "b29sIGl3bF9yZXN1bWVfc3RhdHVzX2ZuKHN0cnVjdCBpd2xfbm90aWZfd2FpdF9kYXRhICpub3Rp\n" - "Zl93YWl0LA0KPiAgDQo+ICAJaWYgKGl3bF9yeF9wYWNrZXRfcGF5bG9hZF9sZW4ocGt0KSAhPSBz\n" - "aXplb2YoKnJlc3VtZV9kYXRhLT5jbWQpKSB7DQo+ICAJCUlXTF9FUlIocHJpdiwgInJ4IHdyb25n\n" - "IHNpemUgZGF0YVxuIik7DQo+IC0JCXJldHVybiB0cnVlOw0KPiArCQlyZXR1cm4gZmFsc2U7DQo+\n" - "ICAJfQ0KPiAgCW1lbWNweShyZXN1bWVfZGF0YS0+Y21kLCBwa3QtPmRhdGEsIHNpemVvZigqcmVz\n" - dW1lX2RhdGEtPmNtZCkpOw0KPiAgCXJlc3VtZV9kYXRhLT52YWxpZCA9IHRydWU7DQoNCg== + "On Wed, 2015-06-10 at 12:33 -0400, Nicholas Krause wrote:\n" + "> This makes the function iwl_resume_status_fn return false now if\n" + "> the received packet of type iwl_rx_packet is not the same size\n" + "> as the structure pointer, iwl_resume_data's cmd element in order\n" + "> to signal callers about this error and allow them to handle it\n" + "> occurrently.\n" + "> \n" + "\n" + "Hm... Did you actually hit this if?\n" + "I am not sure I really want to wait here (which is what will happen if\n" + "you return false) when we get an unexpected length? I do not expect\n" + "anything besides the response I am waiting for since the firmware is\n" + "handling the GET_STATUS *only* - it just came back from WoWLAN. Bottom\n" + "line, this is really an error path and I prefer to exit and not wait for\n" + "the timeout in that case.\n" + "But I might be missing something?\n" + "\n" + "> Signed-off-by: Nicholas Krause <xerofoify@gmail.com>\n" + "> ---\n" + "> drivers/net/wireless/iwlwifi/dvm/mac80211.c | 2 +-\n" + "> 1 file changed, 1 insertion(+), 1 deletion(-)\n" + "> \n" + "> diff --git a/drivers/net/wireless/iwlwifi/dvm/mac80211.c b/drivers/net/wireless/iwlwifi/dvm/mac80211.c\n" + "> index 5abd62e..21e808c 100644\n" + "> --- a/drivers/net/wireless/iwlwifi/dvm/mac80211.c\n" + "> +++ b/drivers/net/wireless/iwlwifi/dvm/mac80211.c\n" + "> @@ -409,7 +409,7 @@ static bool iwl_resume_status_fn(struct iwl_notif_wait_data *notif_wait,\n" + "> \n" + "> \tif (iwl_rx_packet_payload_len(pkt) != sizeof(*resume_data->cmd)) {\n" + "> \t\tIWL_ERR(priv, \"rx wrong size data\\n\");\n" + "> -\t\treturn true;\n" + "> +\t\treturn false;\n" + "> \t}\n" + "> \tmemcpy(resume_data->cmd, pkt->data, sizeof(*resume_data->cmd));\n" + "> \tresume_data->valid = true;\n" + "\n" + "\303\277\303\264\303\250\302\272{.n\303\207+\302\211\302\267\302\237\302\256\302\211\302\255\302\206+%\302\212\303\213\303\277\302\261\303\251\303\235\302\266\027\302\245\302\212w\303\277\302\272{.n\303\207+\302\211\302\267\302\245\302\212{\302\261\303\276G\302\253\302\235\303\251\303\277\302\212{ay\302\272\035\303\212\302\207\303\232\302\231\303\253,j\a\302\255\302\242f\302\243\302\242\302\267h\302\232\302\217\303\257\302\201\303\252\303\277\302\221\303\252\303\247z_\303\250\302\256\003(\302\255\303\251\302\232\302\216\302\212\303\235\302\242j\"\302\235\303\272\032\302\266\033m\302\247\303\277\303\277\302\276\a\302\253\303\276G\302\253\302\235\303\251\303\277\302\242\302\270?\302\231\302\250\303\250\302\255\303\232&\302\243\303\270\302\247~\302\217\303\241\302\266iO\302\225\303\246\302\254z\302\267\302\232v\303\230^\024\004\032\302\266\033m\302\247\303\277\303\277\303\203\f\303\277\302\266\303\254\303\277\302\242\302\270?\302\226I\302\245" -36d60f608e988e2de077bd1328c5f91048009c552033b3f9114b02387c867c95 +4a324f472f539cb361228260bf9bb6a4c44f8eaee543027755bfb3184d4ca158
diff --git a/a/1.txt b/N2/1.txt index 65d0170..3cda344 100644 --- a/a/1.txt +++ b/N2/1.txt @@ -1,28 +1,35 @@ -T24gV2VkLCAyMDE1LTA2LTEwIGF0IDEyOjMzIC0wNDAwLCBOaWNob2xhcyBLcmF1c2Ugd3JvdGU6 -DQo+IFRoaXMgbWFrZXMgdGhlIGZ1bmN0aW9uIGl3bF9yZXN1bWVfc3RhdHVzX2ZuIHJldHVybiBm -YWxzZSBub3cgaWYNCj4gdGhlIHJlY2VpdmVkIHBhY2tldCBvZiB0eXBlIGl3bF9yeF9wYWNrZXQg -aXMgbm90IHRoZSBzYW1lIHNpemUNCj4gYXMgdGhlIHN0cnVjdHVyZSBwb2ludGVyLCBpd2xfcmVz -dW1lX2RhdGEncyBjbWQgZWxlbWVudCBpbiBvcmRlcg0KPiB0byBzaWduYWwgY2FsbGVycyBhYm91 -dCB0aGlzIGVycm9yIGFuZCBhbGxvdyB0aGVtIHRvIGhhbmRsZSBpdA0KPiBvY2N1cnJlbnRseS4N -Cj4gDQoNCkhtLi4uIERpZCB5b3UgYWN0dWFsbHkgaGl0IHRoaXMgaWY/DQpJIGFtIG5vdCBzdXJl -IEkgcmVhbGx5IHdhbnQgdG8gd2FpdCBoZXJlICh3aGljaCBpcyB3aGF0IHdpbGwgaGFwcGVuIGlm -DQp5b3UgcmV0dXJuIGZhbHNlKSB3aGVuIHdlIGdldCBhbiB1bmV4cGVjdGVkIGxlbmd0aD8gSSBk -byBub3QgZXhwZWN0DQphbnl0aGluZyBiZXNpZGVzIHRoZSByZXNwb25zZSBJIGFtIHdhaXRpbmcg -Zm9yIHNpbmNlIHRoZSBmaXJtd2FyZSBpcw0KaGFuZGxpbmcgdGhlIEdFVF9TVEFUVVMgKm9ubHkq -IC0gaXQganVzdCBjYW1lIGJhY2sgZnJvbSBXb1dMQU4uIEJvdHRvbQ0KbGluZSwgdGhpcyBpcyBy -ZWFsbHkgYW4gZXJyb3IgcGF0aCBhbmQgSSBwcmVmZXIgdG8gZXhpdCBhbmQgbm90IHdhaXQgZm9y -DQp0aGUgdGltZW91dCBpbiB0aGF0IGNhc2UuDQpCdXQgSSBtaWdodCBiZSBtaXNzaW5nIHNvbWV0 -aGluZz8NCg0KPiBTaWduZWQtb2ZmLWJ5OiBOaWNob2xhcyBLcmF1c2UgPHhlcm9mb2lmeUBnbWFp -bC5jb20+DQo+IC0tLQ0KPiAgZHJpdmVycy9uZXQvd2lyZWxlc3MvaXdsd2lmaS9kdm0vbWFjODAy -MTEuYyB8IDIgKy0NCj4gIDEgZmlsZSBjaGFuZ2VkLCAxIGluc2VydGlvbigrKSwgMSBkZWxldGlv -bigtKQ0KPiANCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvbmV0L3dpcmVsZXNzL2l3bHdpZmkvZHZt -L21hYzgwMjExLmMgYi9kcml2ZXJzL25ldC93aXJlbGVzcy9pd2x3aWZpL2R2bS9tYWM4MDIxMS5j -DQo+IGluZGV4IDVhYmQ2MmUuLjIxZTgwOGMgMTAwNjQ0DQo+IC0tLSBhL2RyaXZlcnMvbmV0L3dp -cmVsZXNzL2l3bHdpZmkvZHZtL21hYzgwMjExLmMNCj4gKysrIGIvZHJpdmVycy9uZXQvd2lyZWxl -c3MvaXdsd2lmaS9kdm0vbWFjODAyMTEuYw0KPiBAQCAtNDA5LDcgKzQwOSw3IEBAIHN0YXRpYyBi -b29sIGl3bF9yZXN1bWVfc3RhdHVzX2ZuKHN0cnVjdCBpd2xfbm90aWZfd2FpdF9kYXRhICpub3Rp -Zl93YWl0LA0KPiAgDQo+ICAJaWYgKGl3bF9yeF9wYWNrZXRfcGF5bG9hZF9sZW4ocGt0KSAhPSBz -aXplb2YoKnJlc3VtZV9kYXRhLT5jbWQpKSB7DQo+ICAJCUlXTF9FUlIocHJpdiwgInJ4IHdyb25n -IHNpemUgZGF0YVxuIik7DQo+IC0JCXJldHVybiB0cnVlOw0KPiArCQlyZXR1cm4gZmFsc2U7DQo+ -ICAJfQ0KPiAgCW1lbWNweShyZXN1bWVfZGF0YS0+Y21kLCBwa3QtPmRhdGEsIHNpemVvZigqcmVz -dW1lX2RhdGEtPmNtZCkpOw0KPiAgCXJlc3VtZV9kYXRhLT52YWxpZCA9IHRydWU7DQoNCg== +On Wed, 2015-06-10 at 12:33 -0400, Nicholas Krause wrote: +> This makes the function iwl_resume_status_fn return false now if +> the received packet of type iwl_rx_packet is not the same size +> as the structure pointer, iwl_resume_data's cmd element in order +> to signal callers about this error and allow them to handle it +> occurrently. +> + +Hm... Did you actually hit this if? +I am not sure I really want to wait here (which is what will happen if +you return false) when we get an unexpected length? I do not expect +anything besides the response I am waiting for since the firmware is +handling the GET_STATUS *only* - it just came back from WoWLAN. Bottom +line, this is really an error path and I prefer to exit and not wait for +the timeout in that case. +But I might be missing something? + +> Signed-off-by: Nicholas Krause <xerofoify@gmail.com> +> --- +> drivers/net/wireless/iwlwifi/dvm/mac80211.c | 2 +- +> 1 file changed, 1 insertion(+), 1 deletion(-) +> +> diff --git a/drivers/net/wireless/iwlwifi/dvm/mac80211.c b/drivers/net/wireless/iwlwifi/dvm/mac80211.c +> index 5abd62e..21e808c 100644 +> --- a/drivers/net/wireless/iwlwifi/dvm/mac80211.c +> +++ b/drivers/net/wireless/iwlwifi/dvm/mac80211.c +> @@ -409,7 +409,7 @@ static bool iwl_resume_status_fn(struct iwl_notif_wait_data *notif_wait, +> +> if (iwl_rx_packet_payload_len(pkt) != sizeof(*resume_data->cmd)) { +> IWL_ERR(priv, "rx wrong size data\n"); +> - return true; +> + return false; +> } +> memcpy(resume_data->cmd, pkt->data, sizeof(*resume_data->cmd)); +> resume_data->valid = true; diff --git a/a/content_digest b/N2/content_digest index 7833a97..184d6f7 100644 --- a/a/content_digest +++ b/N2/content_digest @@ -1,49 +1,57 @@ "ref\01433954031-7176-1-git-send-email-xerofoify@gmail.com\0" - "From\0Grumbach, Emmanuel <emmanuel.grumbach@intel.com>\0" + "ref\01433954031-7176-1-git-send-email-xerofoify-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org\0" + "From\0Grumbach, Emmanuel <emmanuel.grumbach-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>\0" "Subject\0Re: [PATCH] iwlwifi:dvm:Return false if resume command data is not same size as received packet for the function iwl_resume_status_fn\0" "Date\0Wed, 10 Jun 2015 16:50:45 +0000\0" - "To\0xerofoify@gmail.com <xerofoify@gmail.com>\0" - "Cc\0linux-kernel@vger.kernel.org <linux-kernel@vger.kernel.org>" + "To\0xerofoify-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org <xerofoify-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>\0" + "Cc\0linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org <linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>" Spinadel - David <david.spinadel@intel.com> + David <david.spinadel-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> Coelho - Luciano <luciano.coelho@intel.com> - ilw@linux.intel.com <ilw@linux.intel.com> - eliad@wizery.com <eliad@wizery.com> + Luciano <luciano.coelho-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> + ilw-VuQAYsv1563Yd54FQh9/CA@public.gmane.org <ilw-VuQAYsv1563Yd54FQh9/CA@public.gmane.org> + eliad-Ix1uc/W3ht7QT0dZR+AlfA@public.gmane.org <eliad-Ix1uc/W3ht7QT0dZR+AlfA@public.gmane.org> Berg - Johannes <johannes.berg@intel.com> - kvalo@codeaurora.org <kvalo@codeaurora.org> - netdev@vger.kernel.org <netdev@vger.kernel.org> - " linux-wireless@vger.kernel.org <linux-wireless@vger.kernel.org>\0" + Johannes <johannes.berg-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> + kvalo-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org <kvalo-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org> + netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org <netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org> + " linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org <linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>\0" "\00:1\0" "b\0" - "T24gV2VkLCAyMDE1LTA2LTEwIGF0IDEyOjMzIC0wNDAwLCBOaWNob2xhcyBLcmF1c2Ugd3JvdGU6\n" - "DQo+IFRoaXMgbWFrZXMgdGhlIGZ1bmN0aW9uIGl3bF9yZXN1bWVfc3RhdHVzX2ZuIHJldHVybiBm\n" - "YWxzZSBub3cgaWYNCj4gdGhlIHJlY2VpdmVkIHBhY2tldCBvZiB0eXBlIGl3bF9yeF9wYWNrZXQg\n" - "aXMgbm90IHRoZSBzYW1lIHNpemUNCj4gYXMgdGhlIHN0cnVjdHVyZSBwb2ludGVyLCBpd2xfcmVz\n" - "dW1lX2RhdGEncyBjbWQgZWxlbWVudCBpbiBvcmRlcg0KPiB0byBzaWduYWwgY2FsbGVycyBhYm91\n" - "dCB0aGlzIGVycm9yIGFuZCBhbGxvdyB0aGVtIHRvIGhhbmRsZSBpdA0KPiBvY2N1cnJlbnRseS4N\n" - "Cj4gDQoNCkhtLi4uIERpZCB5b3UgYWN0dWFsbHkgaGl0IHRoaXMgaWY/DQpJIGFtIG5vdCBzdXJl\n" - "IEkgcmVhbGx5IHdhbnQgdG8gd2FpdCBoZXJlICh3aGljaCBpcyB3aGF0IHdpbGwgaGFwcGVuIGlm\n" - "DQp5b3UgcmV0dXJuIGZhbHNlKSB3aGVuIHdlIGdldCBhbiB1bmV4cGVjdGVkIGxlbmd0aD8gSSBk\n" - "byBub3QgZXhwZWN0DQphbnl0aGluZyBiZXNpZGVzIHRoZSByZXNwb25zZSBJIGFtIHdhaXRpbmcg\n" - "Zm9yIHNpbmNlIHRoZSBmaXJtd2FyZSBpcw0KaGFuZGxpbmcgdGhlIEdFVF9TVEFUVVMgKm9ubHkq\n" - "IC0gaXQganVzdCBjYW1lIGJhY2sgZnJvbSBXb1dMQU4uIEJvdHRvbQ0KbGluZSwgdGhpcyBpcyBy\n" - "ZWFsbHkgYW4gZXJyb3IgcGF0aCBhbmQgSSBwcmVmZXIgdG8gZXhpdCBhbmQgbm90IHdhaXQgZm9y\n" - "DQp0aGUgdGltZW91dCBpbiB0aGF0IGNhc2UuDQpCdXQgSSBtaWdodCBiZSBtaXNzaW5nIHNvbWV0\n" - "aGluZz8NCg0KPiBTaWduZWQtb2ZmLWJ5OiBOaWNob2xhcyBLcmF1c2UgPHhlcm9mb2lmeUBnbWFp\n" - "bC5jb20+DQo+IC0tLQ0KPiAgZHJpdmVycy9uZXQvd2lyZWxlc3MvaXdsd2lmaS9kdm0vbWFjODAy\n" - "MTEuYyB8IDIgKy0NCj4gIDEgZmlsZSBjaGFuZ2VkLCAxIGluc2VydGlvbigrKSwgMSBkZWxldGlv\n" - "bigtKQ0KPiANCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvbmV0L3dpcmVsZXNzL2l3bHdpZmkvZHZt\n" - "L21hYzgwMjExLmMgYi9kcml2ZXJzL25ldC93aXJlbGVzcy9pd2x3aWZpL2R2bS9tYWM4MDIxMS5j\n" - "DQo+IGluZGV4IDVhYmQ2MmUuLjIxZTgwOGMgMTAwNjQ0DQo+IC0tLSBhL2RyaXZlcnMvbmV0L3dp\n" - "cmVsZXNzL2l3bHdpZmkvZHZtL21hYzgwMjExLmMNCj4gKysrIGIvZHJpdmVycy9uZXQvd2lyZWxl\n" - "c3MvaXdsd2lmaS9kdm0vbWFjODAyMTEuYw0KPiBAQCAtNDA5LDcgKzQwOSw3IEBAIHN0YXRpYyBi\n" - "b29sIGl3bF9yZXN1bWVfc3RhdHVzX2ZuKHN0cnVjdCBpd2xfbm90aWZfd2FpdF9kYXRhICpub3Rp\n" - "Zl93YWl0LA0KPiAgDQo+ICAJaWYgKGl3bF9yeF9wYWNrZXRfcGF5bG9hZF9sZW4ocGt0KSAhPSBz\n" - "aXplb2YoKnJlc3VtZV9kYXRhLT5jbWQpKSB7DQo+ICAJCUlXTF9FUlIocHJpdiwgInJ4IHdyb25n\n" - "IHNpemUgZGF0YVxuIik7DQo+IC0JCXJldHVybiB0cnVlOw0KPiArCQlyZXR1cm4gZmFsc2U7DQo+\n" - "ICAJfQ0KPiAgCW1lbWNweShyZXN1bWVfZGF0YS0+Y21kLCBwa3QtPmRhdGEsIHNpemVvZigqcmVz\n" - dW1lX2RhdGEtPmNtZCkpOw0KPiAgCXJlc3VtZV9kYXRhLT52YWxpZCA9IHRydWU7DQoNCg== + "On Wed, 2015-06-10 at 12:33 -0400, Nicholas Krause wrote:\n" + "> This makes the function iwl_resume_status_fn return false now if\n" + "> the received packet of type iwl_rx_packet is not the same size\n" + "> as the structure pointer, iwl_resume_data's cmd element in order\n" + "> to signal callers about this error and allow them to handle it\n" + "> occurrently.\n" + "> \n" + "\n" + "Hm... Did you actually hit this if?\n" + "I am not sure I really want to wait here (which is what will happen if\n" + "you return false) when we get an unexpected length? I do not expect\n" + "anything besides the response I am waiting for since the firmware is\n" + "handling the GET_STATUS *only* - it just came back from WoWLAN. Bottom\n" + "line, this is really an error path and I prefer to exit and not wait for\n" + "the timeout in that case.\n" + "But I might be missing something?\n" + "\n" + "> Signed-off-by: Nicholas Krause <xerofoify@gmail.com>\n" + "> ---\n" + "> drivers/net/wireless/iwlwifi/dvm/mac80211.c | 2 +-\n" + "> 1 file changed, 1 insertion(+), 1 deletion(-)\n" + "> \n" + "> diff --git a/drivers/net/wireless/iwlwifi/dvm/mac80211.c b/drivers/net/wireless/iwlwifi/dvm/mac80211.c\n" + "> index 5abd62e..21e808c 100644\n" + "> --- a/drivers/net/wireless/iwlwifi/dvm/mac80211.c\n" + "> +++ b/drivers/net/wireless/iwlwifi/dvm/mac80211.c\n" + "> @@ -409,7 +409,7 @@ static bool iwl_resume_status_fn(struct iwl_notif_wait_data *notif_wait,\n" + "> \n" + "> \tif (iwl_rx_packet_payload_len(pkt) != sizeof(*resume_data->cmd)) {\n" + "> \t\tIWL_ERR(priv, \"rx wrong size data\\n\");\n" + "> -\t\treturn true;\n" + "> +\t\treturn false;\n" + "> \t}\n" + "> \tmemcpy(resume_data->cmd, pkt->data, sizeof(*resume_data->cmd));\n" + "> \tresume_data->valid = true;" -36d60f608e988e2de077bd1328c5f91048009c552033b3f9114b02387c867c95 +154067948a649f19c915171471021124e8e094ae92ea4c32f7af4401f49d5eed
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.