From: Joe Perches <joe@perches.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Steven Rostedt <rostedt@goodmis.org>,
linux-kernel@vger.kernel.org, jkosina@suse.cz,
paulmck@linux.vnet.ibm.com, pmladek@suse.cz,
Ingo Molnar <mingo@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [RFC][PATCH] printk: Fixup the nmi printk mess
Date: Wed, 10 Jun 2015 12:39:53 -0700 [thread overview]
Message-ID: <1433965193.32331.23.camel@perches.com> (raw)
In-Reply-To: <20150610192516.GK3644@twins.programming.kicks-ass.net>
On Wed, 2015-06-10 at 21:25 +0200, Peter Zijlstra wrote:
> On Wed, Jun 10, 2015 at 09:19:16AM -0700, Joe Perches wrote:
> > On Wed, 2015-06-10 at 12:02 -0400, Steven Rostedt wrote:
> >
> > > BTW, the printk.c file is getting rather big.
> >
> > No joke that.
>
> $ find kernel/ -type f -name \*.[ch] | while read file; do wc -l $file; done | sort -nr | awk '{ print ++i " " $0 }' | grep "\<printk\.c"
> 13 3245 kernel/printk/printk.c
>
> so its the 13th biggest file in kernel/, can't really be bothered by that.
printk.c is ~80k of fairly convoluted.
Refactoring would help maintenance.
prev parent reply other threads:[~2015-06-10 19:40 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-10 12:55 [RFC][PATCH] printk: Fixup the nmi printk mess Peter Zijlstra
2015-06-10 14:31 ` Petr Mladek
2015-06-10 14:57 ` Petr Mladek
2015-06-10 15:32 ` Peter Zijlstra
2015-06-10 15:54 ` Steven Rostedt
2015-06-10 15:29 ` Peter Zijlstra
2015-06-10 19:23 ` Peter Zijlstra
2015-06-10 19:36 ` Peter Zijlstra
2015-06-10 19:36 ` Steven Rostedt
2015-06-11 14:55 ` Petr Mladek
2015-06-12 12:00 ` Peter Zijlstra
2015-06-12 14:28 ` Petr Mladek
2015-06-12 15:35 ` Petr Mladek
2015-06-25 18:14 ` Peter Zijlstra
2015-06-26 8:06 ` Petr Mladek
2015-06-11 9:57 ` Petr Mladek
2015-06-10 15:53 ` Steven Rostedt
2015-06-10 16:02 ` Steven Rostedt
2015-06-10 16:19 ` Joe Perches
2015-06-10 19:25 ` Peter Zijlstra
2015-06-10 19:35 ` Steven Rostedt
2015-06-10 19:39 ` Joe Perches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1433965193.32331.23.camel@perches.com \
--to=joe@perches.com \
--cc=jkosina@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=paulmck@linux.vnet.ibm.com \
--cc=peterz@infradead.org \
--cc=pmladek@suse.cz \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.