From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH v2 COLOPre 05/13] tools/libxl: introduce a new API libxl__domain_restore() to load qemu state Date: Thu, 11 Jun 2015 10:41:13 +0100 Message-ID: <1434015673.30003.138.camel@citrix.com> References: <1433734997-26570-1-git-send-email-yanghy@cn.fujitsu.com> <1433734997-26570-6-git-send-email-yanghy@cn.fujitsu.com> <1433950514.30003.101.camel@citrix.com> <5578EDF2.3000201@cn.fujitsu.com> <1434012188.30003.118.camel@citrix.com> <55794CE9.7040607@cn.fujitsu.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <55794CE9.7040607@cn.fujitsu.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Yang Hongyang Cc: wei.liu2@citrix.com, wency@cn.fujitsu.com, Stefano Stabellini , andrew.cooper3@citrix.com, yunhong.jiang@intel.com, eddie.dong@intel.com, xen-devel@lists.xen.org, rshriram@cs.ubc.ca, guijianfeng@cn.fujitsu.com, Anthony Perard , ian.jackson@eu.citrix.com List-Id: xen-devel@lists.xenproject.org On Thu, 2015-06-11 at 16:55 +0800, Yang Hongyang wrote: > > On 06/11/2015 04:43 PM, Ian Campbell wrote: > > On Thu, 2015-06-11 at 10:09 +0800, Yang Hongyang wrote: > >> > >> On 06/10/2015 11:35 PM, Ian Campbell wrote: > >>> On Mon, 2015-06-08 at 11:43 +0800, Yang Hongyang wrote: > >>>> Secondary vm is running in colo mode. So we will do > >>>> the following things again and again: > >>>> 1. suspend both primay vm and secondary vm > >>>> 2. sync the state > >>>> 3. resume both primary vm and secondary vm > >>>> We will send qemu's state each time in step2, and > >>>> slave's qemu should read it each time before resuming > >>>> secondary vm. Introduce a new API libxl__domain_restore() > >>>> to do it. This API should be called before resuming > >>>> secondary vm. > >>> > >>> Is this a preexisting qemu interface or one to be added? > >> > >> We added the qemu interface "xen-load-devices-state", > >> it's not in qemu upstream yet. > > > > OK, please mention this dependency in the commit text since we will want > > to be sure the interface is going to be accepted in this form by QEMU > > upstream before we start using it. Please also CC the QEMU maintainers > > on this patch in the future (by adding Cc: below the S-o-b if you don't > > want to spam them the whole series), I've added them here now. > > > > In particular "devices" seems odd to me, perhaps > > "xen-load-device-state"? > > This api is an invert operation to "xen-save-devices-stat", we used the name > "xen-load-devices-state" in order to follow the existing naming style... OK, I guess it'll do then, thanks.