From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <ian.campbell@citrix.com>
Subject: Re: [PATCH v2 COLOPre 06/13] tools/libxl: Introduce a
 new internal API libxl__domain_unpause()
Date: Thu, 11 Jun 2015 10:42:45 +0100
Message-ID: <1434015765.30003.140.camel@citrix.com>
References: <1433734997-26570-1-git-send-email-yanghy@cn.fujitsu.com>
	<1433734997-26570-7-git-send-email-yanghy@cn.fujitsu.com>
	<1433950640.30003.103.camel@citrix.com>
	<5578F0A3.5060208@cn.fujitsu.com>
	<1434012212.30003.119.camel@citrix.com>
	<55795061.9020506@cn.fujitsu.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <55795061.9020506@cn.fujitsu.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Wen Congyang <wency@cn.fujitsu.com>
Cc: wei.liu2@citrix.com, andrew.cooper3@citrix.com, yunhong.jiang@intel.com, eddie.dong@intel.com, xen-devel@lists.xen.org, guijianfeng@cn.fujitsu.com, rshriram@cs.ubc.ca, Yang Hongyang <yanghy@cn.fujitsu.com>, ian.jackson@eu.citrix.com
List-Id: xen-devel@lists.xenproject.org

On Thu, 2015-06-11 at 17:09 +0800, Wen Congyang wrote:
> On 06/11/2015 04:43 PM, Ian Campbell wrote:
> > On Thu, 2015-06-11 at 10:21 +0800, Yang Hongyang wrote:
> >>
> >> On 06/10/2015 11:37 PM, Ian Campbell wrote:
> >>> On Mon, 2015-06-08 at 11:43 +0800, Yang Hongyang wrote:
> >>>> From: Wen Congyang <wency@cn.fujitsu.com>
> >>>>
> >>>> The guest is paused after libxl_domain_create_restore().
> >>>> Secondary vm is running in colo mode. So we need to unpause
> >>>> the guest. The current API libxl_domain_unpause() is
> >>>> not an internal API. Introduce a new API to support it.
> >>>> No functional change.
> >>>
> >>> In general there is nothing wrong with using a public function
> >>> internally. Is there some special consideration here?
> >>
> >> It's just that we thought it's better to use internal functions for
> >> internal purpose.
> >> Most the public functions take ctx as the first param, the internal functions
> >> take gc/egc as the first param(although we can get ctx from gcs and call
> >> public functions when needed).
> >> If it doesn't matter, we can drop this patch.
> > 
> > It doesn't matter so you can, yes.
> 
> If the public API creates a new AO, it is safe to call it directly?

A public function which takes an ao_how is, I believe, an exception to
this rule and should be annotated with LIBXL_EXTERNAL_CALLERS_ONLY to
prevent accidents.

I don't think libxl_domain_unpause is such a function though.

Ian.