Re: [PATCHv2 1/4] cfg80211: handle minimum bandwidth for quarter and half rates

[Johannes Berg <johannes@sipsolutions.net>]

On Thu, 2015-06-11 at 13:06 +0200, Matthias May wrote:

>  const struct ieee80211_reg_rule *freq_reg_info(struct wiphy *wiphy,
> -					       u32 center_freq)
> +					       u32 center_freq, u32 min_bw)
>  {
>  	const struct ieee80211_regdomain *regd;
> +	const struct ieee80211_reg_rule *rr_tmp = NULL;
> +	const struct ieee80211_reg_rule *reg_rule = NULL;
> +	u32 bw;
>  
>  	regd = reg_get_regdomain(wiphy);
>  
> -	return freq_reg_info_regd(wiphy, center_freq, regd);
> +	for(bw=min_bw; bw <= MHZ_TO_KHZ(20); bw=bw*2) {
> +		rr_tmp = freq_reg_info_regd(wiphy, center_freq, bw, regd);
> +		if(!reg_rule || !IS_ERR(rr_tmp))
> +			reg_rule = rr_tmp;
> +	}
> +
> +	return reg_rule;

This makes no sense to me.

You have the same code below, but why would you care? You can just look
at the reg_rule's max_bandwidth, no?

johannes