From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: Narsimhulu Musini <nmusini@cisco.com>
Cc: linux-scsi@vger.kernel.org, hare@suse.de, boaz@plexistor.com,
jthumshirn@suse.de, Sesidhar Baddela <sebaddel@cisco.com>
Subject: Re: [PATCH v7 7/9] snic:Add sysfs entries to list stats and trace data
Date: Sat, 13 Jun 2015 09:17:32 -0700 [thread overview]
Message-ID: <1434212252.2208.4.camel@HansenPartnership.com> (raw)
In-Reply-To: <1432886649-12034-8-git-send-email-nmusini@cisco.com>
On Fri, 2015-05-29 at 01:04 -0700, Narsimhulu Musini wrote:
> +static const struct file_operations snic_stats_fops __read_mostly = {
> + .owner = THIS_MODULE,
> + .open = snic_stats_open,
> + .read = seq_read,
> + .llseek = seq_lseek,
> + .release = single_release,
> +};
Checkpatch hates this for obvious reasons: a const structure has to be
read only, not read mostly, so it's a section conflict. I fixed it up,
but running the code through checkpatch would have flagged it as an
error.
James
next prev parent reply other threads:[~2015-06-13 16:17 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-29 8:04 [PATCH v7 0/9] snic:initial submission of snic driver for Cisco SCSI HBA Narsimhulu Musini
2015-05-29 8:04 ` [PATCH v7 1/9] snic: snic module infrastructure Narsimhulu Musini
2015-05-29 13:46 ` Hannes Reinecke
2015-05-29 8:04 ` [PATCH v7 2/9] snic:Add interrupt, resource firmware interfaces Narsimhulu Musini
2015-05-29 13:48 ` Hannes Reinecke
2015-05-29 8:04 ` [PATCH v7 3/9] snic:Add meta request, handling of meta requests Narsimhulu Musini
2015-05-29 13:51 ` Hannes Reinecke
2015-05-29 8:04 ` [PATCH v7 4/9] snic:Add snic target discovery Narsimhulu Musini
2015-05-29 13:57 ` Hannes Reinecke
2015-05-29 8:04 ` [PATCH v7 5/9] snic:add SCSI handling, AEN, and fwreset handling Narsimhulu Musini
2015-05-29 14:03 ` Hannes Reinecke
2015-05-29 8:04 ` [PATCH v7 6/9] snic:Add low level queuing interfaces Narsimhulu Musini
2015-05-29 14:05 ` Hannes Reinecke
2015-05-29 8:04 ` [PATCH v7 7/9] snic:Add sysfs entries to list stats and trace data Narsimhulu Musini
2015-05-29 14:05 ` Hannes Reinecke
2015-06-13 16:17 ` James Bottomley [this message]
2015-06-15 4:18 ` Narsimhulu Musini (nmusini)
2015-05-29 8:04 ` [PATCH v7 8/9] snic:Add event tracing to capture IO events Narsimhulu Musini
2015-05-29 14:05 ` Hannes Reinecke
2015-06-13 16:20 ` James Bottomley
2015-06-15 4:19 ` Narsimhulu Musini (nmusini)
2015-05-29 8:04 ` [PATCH v7 9/9] snic:Add Makefile, patch Kconfig, MAINTAINERS Narsimhulu Musini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1434212252.2208.4.camel@HansenPartnership.com \
--to=james.bottomley@hansenpartnership.com \
--cc=boaz@plexistor.com \
--cc=hare@suse.de \
--cc=jthumshirn@suse.de \
--cc=linux-scsi@vger.kernel.org \
--cc=nmusini@cisco.com \
--cc=sebaddel@cisco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.