All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ramiro Morales <cramm0@gmail.com>
To: hmh@hmh.eng.br, dvhart@infradead.org
Cc: ibm-acpi-devel@lists.sourceforge.net,
	platform-driver-x86@vger.kernel.org,
	Ramiro Morales <cramm0@gmail.com>
Subject: [PATCH 1/1] thinkpad-acpi: Reduce screen brightness user visible noise.
Date: Mon, 15 Jun 2015 12:29:14 -0300	[thread overview]
Message-ID: <1434382154-3046-1-git-send-email-cramm0@gmail.com> (raw)
In-Reply-To: <20150614022755.GB26753@khazad-dum.debian.net>

Implement change in logging during screen brightness capabilities
detection as suggested in
https://www.mail-archive.com/ibm-acpi-devel%40lists.sourceforge.net/msg03484.html

Signed-off-by: Ramiro Morales <cramm0@gmail.com>
---
 drivers/platform/x86/thinkpad_acpi.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/platform/x86/thinkpad_acpi.c b/drivers/platform/x86/thinkpad_acpi.c
index 28f3281..b48efc9 100644
--- a/drivers/platform/x86/thinkpad_acpi.c
+++ b/drivers/platform/x86/thinkpad_acpi.c
@@ -6450,19 +6450,16 @@ static void __init tpacpi_detect_brightness_capabilities(void)
 	switch (b) {
 	case 16:
 		bright_maxlvl = 15;
-		pr_info("detected a 16-level brightness capable ThinkPad\n");
 		break;
 	case 8:
 	case 0:
 		bright_maxlvl = 7;
-		pr_info("detected a 8-level brightness capable ThinkPad\n");
 		break;
 	default:
-		pr_err("Unsupported brightness interface, "
-		       "please contact %s\n", TPACPI_MAIL);
 		tp_features.bright_unkfw = 1;
 		bright_maxlvl = b - 1;
 	}
+	pr_debug("firmware reports %d brightness levels\n", bright_maxlvl);
 }
 
 static int __init brightness_init(struct ibm_init_struct *iibm)
@@ -6482,6 +6479,9 @@ static int __init brightness_init(struct ibm_init_struct *iibm)
 
 	/* if it is unknown, we don't handle it: it wouldn't be safe */
 	if (tp_features.bright_unkfw)
+		dbg_printk(TPACPI_DBG_INIT | TPACPI_DBG_BRGHT,
+			   "Unsupported brightness mode, use acpi video "
+			   "or gpu drivers");
 		return 1;
 
 	if (!brightness_enable) {
-- 
1.9.1

       reply	other threads:[~2015-06-15 15:29 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20150614022755.GB26753@khazad-dum.debian.net>
2015-06-15 15:29 ` Ramiro Morales [this message]
2015-06-15 17:06   ` [PATCH 1/1] thinkpad-acpi: Reduce screen brightness user visible noise Henrique de Moraes Holschuh
2015-06-15 20:43   ` Darren Hart

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1434382154-3046-1-git-send-email-cramm0@gmail.com \
    --to=cramm0@gmail.com \
    --cc=dvhart@infradead.org \
    --cc=hmh@hmh.eng.br \
    --cc=ibm-acpi-devel@lists.sourceforge.net \
    --cc=platform-driver-x86@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.