From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH v2 5/6] gnttab: fix/adjust gnttab_transfer() Date: Tue, 16 Jun 2015 09:52:14 +0100 Message-ID: <1434444734.13744.54.camel@citrix.com> References: <557EDDDD0200007800084C94@mail.emea.novell.com> <557EE0F50200007800084CE1@mail.emea.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1Z4mbT-0003Gz-Qj for xen-devel@lists.xenproject.org; Tue, 16 Jun 2015 08:52:19 +0000 In-Reply-To: <557EE0F50200007800084CE1@mail.emea.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Jan Beulich Cc: xen-devel , Keir Fraser , Ian Jackson , Tim Deegan List-Id: xen-devel@lists.xenproject.org On Mon, 2015-06-15 at 13:28 +0100, Jan Beulich wrote: > - don't update shared entry's frame number for translated domains (as > MFNs shouldn't be exposed to such guests) > - for v1 grant table format, force copying of the page also when the > intended MFN doesn't fit in 32 bits (and the domain isn't translated) > - fix an apparent off-by-one error (it's unclear to me why commit > 5cc77f9098 ("32-on-64: Fix domain address-size clamping, implement") > uses BITS_PER_LONG-1 here, while using BITS_PER_LONG in the two other > invocations of domain_clamp_alloc_bitsize()) > - adjust comments accompanying the shared entry's frame field > > Signed-off-by: Jan Beulich Acked-by: Ian Campbell