From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <ian.campbell@citrix.com>
Subject: Re: [OSSTEST PATCH 11/12] reporting: Show slightly
 better info for broken jobs
Date: Tue, 16 Jun 2015 10:07:43 +0100
Message-ID: <1434445663.13744.73.camel@citrix.com>
References: <1434388394-26099-1-git-send-email-ian.jackson@eu.citrix.com>
	<1434388394-26099-12-git-send-email-ian.jackson@eu.citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta5.messagelabs.com ([195.245.231.135])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <prvs=6024c1d16=Ian.Campbell@citrix.com>)
	id 1Z4mqV-0006Nf-6f
	for xen-devel@lists.xenproject.org; Tue, 16 Jun 2015 09:07:51 +0000
In-Reply-To: <1434388394-26099-12-git-send-email-ian.jackson@eu.citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ian Jackson <ian.jackson@eu.citrix.com>
Cc: xen-devel@lists.xenproject.org
List-Id: xen-devel@lists.xenproject.org

On Mon, 2015-06-15 at 18:13 +0100, Ian Jackson wrote:
> Signed-off-by: Ian Jackson <ian.jackson@eu.citrix.com>
> ---
>  Osstest/Executive.pm |    9 ++++++---
>  1 file changed, 6 insertions(+), 3 deletions(-)
> 
> diff --git a/Osstest/Executive.pm b/Osstest/Executive.pm
> index 6edbfee..6c16fdd 100644
> --- a/Osstest/Executive.pm
> +++ b/Osstest/Executive.pm
> @@ -204,7 +204,8 @@ sub report_run_getinfo ($) {
>      my $status= $f->{status};
>      if ($status eq 'pass') {
>          return { Summary => "($status)", Colour => $green };
> -    } elsif ($status eq 'fail') {
> +    } elsif ($status eq 'fail' or $status eq 'broken') {
> +	my $failcolour = $status eq 'fail' ? $red : $yellow;
>  	our $failstepq //= db_prepare(<<END);
>  	    SELECT * FROM steps
>  	     WHERE flight=? AND job=?
> @@ -217,10 +218,12 @@ END
>          if (!defined $fs) {
>              return { Summary => "(unknown)", Colour => $yellow };
>          } elsif ($fs->{status} eq 'fail') {
> -            return { Summary => "$fs->{testid}", Colour => $red };
> +            return { Summary => "$fs->{testid}", Colour => $failcolour };
> +        } elsif ($fs->{status} eq 'broken') {
> +            return { Summary => "$fs->{testid} broken", Colour => $yellow };

Not $failcolour?

(Or alternatively why is the fail case changing if not)

>          } else {
>              return { Summary => "$fs->{testid} $fs->{status}",
> -                     Colour => $red };
> +                     Colour => $failcolour };
>          }
>      } elsif ($status eq 'blocked') {
>          return { Summary => "blocked", Colour => $purple },