From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <ian.campbell@citrix.com>
Subject: Re: [OSSTEST PATCH 11/12] reporting: Show slightly
 better info for broken jobs
Date: Tue, 16 Jun 2015 11:19:49 +0100
Message-ID: <1434449989.13744.84.camel@citrix.com>
References: <1434388394-26099-1-git-send-email-ian.jackson@eu.citrix.com>
	<1434388394-26099-12-git-send-email-ian.jackson@eu.citrix.com>
	<1434445663.13744.73.camel@citrix.com>
	<21887.63177.519589.503167@mariner.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta3.messagelabs.com ([195.245.230.39])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <prvs=6024c1d16=Ian.Campbell@citrix.com>)
	id 1Z4nyF-0006K7-54
	for xen-devel@lists.xenproject.org; Tue, 16 Jun 2015 10:19:55 +0000
In-Reply-To: <21887.63177.519589.503167@mariner.uk.xensource.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ian Jackson <Ian.Jackson@eu.citrix.com>
Cc: xen-devel@lists.xenproject.org
List-Id: xen-devel@lists.xenproject.org

On Tue, 2015-06-16 at 11:13 +0100, Ian Jackson wrote:
> Ian Campbell writes ("Re: [OSSTEST PATCH 11/12] reporting: Show slightly better info for broken jobs"):
> > On Mon, 2015-06-15 at 18:13 +0100, Ian Jackson wrote:
> > > Signed-off-by: Ian Jackson <ian.jackson@eu.citrix.com>
> ...
> > > -    } elsif ($status eq 'fail') {
> > > +    } elsif ($status eq 'fail' or $status eq 'broken') {
> > > +	my $failcolour = $status eq 'fail' ? $red : $yellow;
> > >  	our $failstepq //= db_prepare(<<END);
> > >  	    SELECT * FROM steps
> > >  	     WHERE flight=? AND job=?
> > > @@ -217,10 +218,12 @@ END
> > >          if (!defined $fs) {
> > >              return { Summary => "(unknown)", Colour => $yellow };
> > >          } elsif ($fs->{status} eq 'fail') {
> > > -            return { Summary => "$fs->{testid}", Colour => $red };
> > > +            return { Summary => "$fs->{testid}", Colour => $failcolour };
> > > +        } elsif ($fs->{status} eq 'broken') {
> > > +            return { Summary => "$fs->{testid} broken", Colour => $yellow };
> > 
> > Not $failcolour?
> 
> Using $failcolour instead of $yellow there would only make a
> difference if the job was `fail' but the step was `broken'.  So this
> is a bit of an edge case.
> 
> But I think in that situation $red is probably better, so I will
> change this.

OK. You can put my Ack on it if you like.

Ian.