From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <ian.campbell@citrix.com>
Subject: Re: [PATCH v6 1/8] xenalyze: add to tools/xentrace/
Date: Tue, 16 Jun 2015 11:35:42 +0100
Message-ID: <1434450942.13744.92.camel@citrix.com>
References: <1434040245-22195-1-git-send-email-olaf@aepfle.de>
	<1434040245-22195-2-git-send-email-olaf@aepfle.de>
	<1434450279.13744.88.camel@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1434450279.13744.88.camel@citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Olaf Hering <olaf@aepfle.de>
Cc: George Dunlap <george.dunlap@eu.citrix.com>, Ian Jackson <ian.jackson@eu.citrix.com>, xen-devel@lists.xen.org, Wei Liu <wei.liu2@citrix.com>, Stefano Stabellini <stefano.stabellini@eu.citrix.com>
List-Id: xen-devel@lists.xenproject.org

On Tue, 2015-06-16 at 11:24 +0100, Ian Campbell wrote:
> On Thu, 2015-06-11 at 16:30 +0000, Olaf Hering wrote:
> > @@ -26,6 +28,7 @@ install: build
> >  	[ -z "$(LIBBIN)" ] || $(INSTALL_DIR) $(DESTDIR)$(LIBEXEC_BIN)
> >  	$(INSTALL_DIR) $(DESTDIR)$(MAN1DIR)
> >  	$(INSTALL_DIR) $(DESTDIR)$(MAN8DIR)
> > +	$(INSTALL_PROG) $(BIN) $(DESTDIR)$(bindir)
> 
> Building on !x86 fails here because $(BIN) is empty:
> install: missing destination file operand after `/local/scratch/ianc/devel/committer-arm32.git/dist/install/usr/local/bin'
> Try `install --help' for more information.
> 
> I propose to continue trying to commit with this fixup patch folded
> in:

This didn't succeed because $(BIN) at this point is actually ' ', not
''. Due to the BIN += $(BIN-y), which is approximately:
        BIN := '$(BIN) $(BIN-y)'

Since in the context it doesn't yet matter, I'll fold in this too:

@@ -6,9 +6,8 @@ CFLAGS += -Werror
 CFLAGS += $(CFLAGS_libxenctrl)
 LDLIBS += $(LDLIBS_libxenctrl)
 
-BIN      =
 BIN-$(CONFIG_X86) = xenalyze
-BIN     += $(BIN-y)
+BIN      = $(BIN-y)
 SBIN     = xentrace xentrace_setsize
 LIBBIN   = xenctx
 SCRIPTS  = xentrace_format