From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH v2 COLOPre 08/13] tools/libxl: introduce libxl__domain_common_switch_qemu_logdirty() Date: Tue, 16 Jun 2015 11:45:32 +0100 Message-ID: <1434451532.13744.94.camel@citrix.com> References: <1433734997-26570-1-git-send-email-yanghy@cn.fujitsu.com> <1433734997-26570-9-git-send-email-yanghy@cn.fujitsu.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1433734997-26570-9-git-send-email-yanghy@cn.fujitsu.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Yang Hongyang , ian.jackson@eu.citrix.com Cc: wei.liu2@citrix.com, wency@cn.fujitsu.com, andrew.cooper3@citrix.com, yunhong.jiang@intel.com, eddie.dong@intel.com, xen-devel@lists.xen.org, guijianfeng@cn.fujitsu.com, rshriram@cs.ubc.ca List-Id: xen-devel@lists.xenproject.org On Mon, 2015-06-08 at 11:43 +0800, Yang Hongyang wrote: > Secondary vm is running in colo mode, we need to send > secondary vm's dirty page information to master at checkpoint, > so we have to enable qemu logdirty on secondary. > > libxl__domain_suspend_common_switch_qemu_logdirty() is to enable > qemu logdirty. But it uses domain_save_state, and calls > libxl__xc_domain_saverestore_async_callback_done() > before exits. This can not be used for secondary vm. > > Update libxl__domain_suspend_common_switch_qemu_logdirty() to > introduce a new API libxl__domain_common_switch_qemu_logdirty(). > This API only uses libxl__logdirty_switch, and calls > lds->callback before exits. > > Signed-off-by: Yang Hongyang > Signed-off-by: Wen Congyang Acked-by: Ian Campbell