From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Changhyeok Bae <changhyeok.bae@lge.com>
Cc: 이명구 <myonggu.lee@lge.com>, openembedded-core@lists.openembedded.org
Subject: Re: [PATCH] {python, python3}-native: fix TypeError
Date: Tue, 16 Jun 2015 15:32:41 +0100 [thread overview]
Message-ID: <1434465161.19270.17.camel@linuxfoundation.org> (raw)
In-Reply-To: <022401d0a7f5$f1102e60$d3308b20$@lge.com>
On Tue, 2015-06-16 at 14:33 +0900, Changhyeok Bae wrote:
> Doesn't this mean BUILD_SYS or HOST_SYS weren't set in the environment?
> -> You're right. The default env value of BUILD_SYS and HOST_SYS is "" (empty).
> -> I wonder that the original patch (12-distutils-prefix-is-inside-staging-area.patch) to add is required?
>
> Wouldn't this patch just mean you get a value of something like "None"?
> -> My patch is to prevent errors in runtime.
> -> Do you have any other good idea?
My concern is that just having a value of "None" means the code trying
to use this variable will probably do the wrong thing. We should try and
fix the underlying problem of BUILD_SYS bot being set when it should be,
rather than just hide the runtime error.
How you do that depends on when the runtime error is occurring which I
know little about...
Cheers,
Richard
prev parent reply other threads:[~2015-06-16 14:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-09 5:08 [PATCH] {python,python3}-native: fix TypeError Changhyeok Bae
2015-06-15 6:48 ` [PATCH] {python, python3}-native: " Changhyeok Bae
2015-06-15 6:54 ` Richard Purdie
2015-06-16 5:33 ` Changhyeok Bae
2015-06-16 14:32 ` Richard Purdie [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1434465161.19270.17.camel@linuxfoundation.org \
--to=richard.purdie@linuxfoundation.org \
--cc=changhyeok.bae@lge.com \
--cc=myonggu.lee@lge.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.