From: Johannes Berg <johannes@sipsolutions.net>
To: agreen@cococorp.com
Cc: linux-wireless@vger.kernel.org, Jesse Jones <jjones@cococorp.com>
Subject: Re: [PATCH] mac80211: don't invalidate SN on discovery failure
Date: Wed, 17 Jun 2015 10:58:57 +0200 [thread overview]
Message-ID: <1434531537.1884.17.camel@sipsolutions.net> (raw)
In-Reply-To: <557B4B65.60001@cococorp.com> (sfid-20150612_231319_185504_F3077021)
On Fri, 2015-06-12 at 14:13 -0700, Alexis Green wrote:
> From: Jesse Jones <jjones@cococorp.com>
>
> The 2012 spec mentions that path SNs can be invalid when created (see
> section 13.10.8.4 table 13-9) but AFAICT never talks about invalidating
> SNs. Which makes sense: if we have figured out the path to a target at a
> certain SN then we want to remember that fact. Failing to do so can lead
> to routing loops because if we don't have a valid SN then we have no way
> of knowing whether an incoming path message leads to or away from the
> target.
>
> However currently when discovery fails we zero out mpath->flags which
> clears MESH_PATH_SN_VALID. This patch fixes that so that only the
> discovery relevant flags are cleared.
Applied; I fixed the indentation a bit.
Also, please mention "mesh" in the future in the subject of your
patches, it makes it easier to pick out.
johannes
prev parent reply other threads:[~2015-06-17 8:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-12 21:13 [PATCH] mac80211: don't invalidate SN on discovery failure Alexis Green
2015-06-17 8:58 ` Johannes Berg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1434531537.1884.17.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=agreen@cococorp.com \
--cc=jjones@cococorp.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.