Re: [PATCH] xen/arm: Propagate clock-frequency to DOMU if present in the DT timer node

[Ian Campbell <ian.campbell@citrix.com>]

On Wed, 2015-06-03 at 15:48 +0100, Julien Grall wrote:
> When the property "clock-frequency" is present in the DT timer node, it
> means that the bootloader/firmware didn't correctly configured the

"configure"

> CNTFRQ/CNTFRQ_EL0 on each processor.
> 
> The best solution would be to fix the offending firmware/bootloader,
> although it may not always be possible to modify and re-flash it.
> 
> As it's not possible to trap the register CNTFRQ/CNTFRQ_EL0, we have
> to extend xen_arch_domainconfig to provide the timer frequency to the
> toolstack when the property "clock-frequency" is present to the host DT
> timer node. Then, a property "clock-frequency" will be created in the guest
> DT timer node if the value is not 0.
> 
> We could have set the property in the guest DT no matter if the property
> is present in the host DT. Although, we still want to let the guest
> using CNTFRQ in normal case. After all, the property "clock-frequency"
> is just a workaround for buggy firmware.
> 
> Signed-off-by: Julien Grall <julien.grall@citrix.com>
> Cc: Chris Brand <chris.brand@broadcom.com>

I was about to apply but:

libxl_arm.c: In function ‘make_timer_node’:
libxl_arm.c:468:9: error: implicit declaration of function ‘fdt_property_u32’ [-Werror=implicit-function-declaration]
cc1: all warnings being treated as errors

That happen on both my 32 bit build (Debian Wheezy) and my 64 bit on
(Ubuntu Saucy).

Ian.



_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel