From: Johannes Berg <johannes@sipsolutions.net>
To: Krishna Chaitanya <chaitanya.mgit@gmail.com>
Cc: linux-wireless <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH V3] mac80211: wowlan: suspend: Fix power save state stuck in ACTIVE caused by race between suspend and Tx packet.
Date: Wed, 17 Jun 2015 13:37:27 +0200 [thread overview]
Message-ID: <1434541047.1884.41.camel@sipsolutions.net> (raw)
In-Reply-To: <CABPxzY+Nz+wOCtot-4ROZJ6SR-a1gV625ak8qmLHtjvR=JadGQ@mail.gmail.com> (sfid-20150617_133542_383000_26A57581)
On Wed, 2015-06-17 at 17:05 +0530, Krishna Chaitanya wrote:
> > Then again, you're talking about WoWLAN, but then ...
> In wowlan, we simply call drv_resume and only if it fails
> then we will go through full resume. And without wowlan
> connection will not be there so this code will not be hit.
Right, but then the important part still is that we're enabling
powersave when going to sleep, no? I mean ... anyway it doesn't matter
much. I'll come up with some better comment/description I guess.
I really hate this whole powersave code btw - we really should refactor
that into its own little library module or so...
johannes
next prev parent reply other threads:[~2015-06-17 11:37 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-10 13:42 [PATCH V3] mac80211: wowlan: suspend: Fix power save state stuck in ACTIVE caused by race between suspend and Tx packet Chaitanya T K
2015-06-17 8:47 ` Johannes Berg
2015-06-17 10:22 ` Krishna Chaitanya
2015-06-17 11:01 ` Johannes Berg
2015-06-17 11:35 ` Krishna Chaitanya
2015-06-17 11:37 ` Johannes Berg [this message]
2015-06-17 12:15 ` Krishna Chaitanya
2015-07-17 9:16 ` Johannes Berg
2015-07-17 9:33 ` Krishna Chaitanya
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1434541047.1884.41.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=chaitanya.mgit@gmail.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.