From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.linuxfoundation.org ([140.211.169.12]:48810 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754063AbbFSSXu (ORCPT ); Fri, 19 Jun 2015 14:23:50 -0400 Subject: Patch "dmaengine: Fix choppy sound because of unimplemented resume" has been added to the 4.0-stable tree To: k.kozlowski@samsung.com, gregkh@linuxfoundation.org, m.szyprowski@samsung.com, maxime.ripard@free-electrons.com, vinod.koul@intel.com Cc: , From: Date: Fri, 19 Jun 2015 11:23:49 -0700 Message-ID: <1434738229119195@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=ANSI_X3.4-1968 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org List-ID: This is a note to let you know that I've just added the patch titled dmaengine: Fix choppy sound because of unimplemented resume to the 4.0-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is: dmaengine-fix-choppy-sound-because-of-unimplemented-resume.patch and it can be found in the queue-4.0 subdirectory. If you, or anyone else, feels it should not be added to the stable tree, please let know about it. >>From 88d04643c66052a1cf92a6fd5f92dff0f7757f61 Mon Sep 17 00:00:00 2001 From: Krzysztof Kozlowski Date: Wed, 10 Jun 2015 17:17:07 +0900 Subject: dmaengine: Fix choppy sound because of unimplemented resume From: Krzysztof Kozlowski commit 88d04643c66052a1cf92a6fd5f92dff0f7757f61 upstream. Some drivers implement only pause operation (no resuming). Example is pl330 where pause is needed for getting residuum. pl330 does not support resume operation, transfer must be stopped after pause. However for slaves this is exposed always as "pause and resume" which introduces subtle errors on Odroid U3 board (Exynos4412 with pl330). After adding pause function to pl330 driver the audio playback (utilizing DMA) gets choppy after some time (approximately 24 hours). Fix this by exposing "cmd_pause" if and only if pause and resume are implemented. Signed-off-by: Krzysztof Kozlowski Reported-by: gabriel@unseen.is Reported-by: Marek Szyprowski Fixes: 88987d2c7534 ("dmaengine: pl330: add DMA_PAUSE feature") Acked-by: Maxime Ripard Signed-off-by: Vinod Koul Signed-off-by: Greg Kroah-Hartman --- drivers/dma/dmaengine.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) --- a/drivers/dma/dmaengine.c +++ b/drivers/dma/dmaengine.c @@ -505,7 +505,11 @@ int dma_get_slave_caps(struct dma_chan * caps->directions = device->directions; caps->residue_granularity = device->residue_granularity; - caps->cmd_pause = !!device->device_pause; + /* + * Some devices implement only pause (e.g. to get residuum) but no + * resume. However cmd_pause is advertised as pause AND resume. + */ + caps->cmd_pause = !!(device->device_pause && device->device_resume); caps->cmd_terminate = !!device->device_terminate_all; return 0; Patches currently in stable-queue which might be from k.kozlowski@samsung.com are queue-4.0/dmaengine-fix-choppy-sound-because-of-unimplemented-resume.patch queue-4.0/dmaengine-pl330-fix-hang-on-dmaengine_terminate_all-on-certain-boards.patch queue-4.0/i2c-s3c2410-fix-oops-in-suspend-callback-for-non-dt.patch -- To unsubscribe from this list: send the line "unsubscribe stable" in