From mboxrd@z Thu Jan 1 00:00:00 1970 From: Imre Deak Subject: Re: [PATCH] drm/i915: enable BIOS hang workaround for Lenovo T60 too Date: Mon, 22 Jun 2015 16:43:50 +0300 Message-ID: <1434980630.31905.88.camel@intel.com> References: <1434694676-2039-1-git-send-email-mikko.rapeli@iki.fi> <20150619154431.GD25769@phenom.ffwll.local> <1434731815.2385.157.camel@x220> Reply-To: imre.deak@intel.com Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1434731815.2385.157.camel@x220> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Paul Bolle Cc: DirkGriesbach , Mikko Rapeli , intel-gfx@lists.freedesktop.org, "Rafael J. Wysocki" , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Ilya Tumaykin List-Id: dri-devel@lists.freedesktop.org T24gcGUsIDIwMTUtMDYtMTkgYXQgMTg6MzYgKzAyMDAsIFBhdWwgQm9sbGUgd3JvdGU6Cj4gT24g RnJpLCAyMDE1LTA2LTE5IGF0IDE3OjQ0ICswMjAwLCBEYW5pZWwgVmV0dGVyIHdyb3RlOgo+ID4g SSB3b25kZXIgd2hldGhlciB3ZSBzaG91bGRuJ3QgZG8gdGhpcyB1bmNvbmRpdGlvbmFsbHkgZm9y IGdlbjQgYW5kIGVhcmxpZXIKPiA+IGZvciBMZW5vdm8gLi4uIEFueXdheSB0aGlzIG5lZWRzIENj OiBzdGFibGVAdmdlci5rZXJuZWwub3JnIGFuZCBpcyBmb3IKPiA+IEphbmkgdG8gcGljayB1cC4K PiA+IAo+ID4gVGhhbmtzIGZvciBmaWd1cmluZyBvdXQgd2hhdCdzIGJlZW4gYnJva2VuIGhlcmUu Cj4gPiAtRGFuaWVsCj4gPiAKPiA+ID4gIAkJcGNpX3NldF9wb3dlcl9zdGF0ZShkcm1fZGV2LT5w ZGV2LCBQQ0lfRDNob3QpOwo+ID4gPiAgCj4gPiA+ICAJcmV0dXJuIDA7Cj4gCj4gSnVzdCB0d28g ZGF5cyBhZ28gd2UgZGlzY3Vzc2VkIHRoaXMgYnVnIHRvbywgc2VlCj4gaHR0cHM6Ly9sa21sLm9y Zy9sa21sLzIwMTUvNi8xNy8zMjcgLiBUaGF0IG1lc3NhZ2UgY29udGFpbnMgYSBsaW5rIHRvIGEK PiBwYXRjaCBJIGNvYmJsZWQgdG9nZXRoZXIgZm9yIHlldCBhbm90aGVyIFRoaW5rUGFkIGhpdHRp bmcgdGhpcywgYnV0IHdpdGgKPiBQQ0lfU1VCVkVORE9SX0lEX0lCTSBpbnZvbHZlZC4KClRvIHN1 bW1hcml6ZSwgc2luY2Ugd2UgZXh0ZW5kZWQgdGhlIHJhbmdlIG9mIHBsYXRmb3JtcyB0byBhcHBs eSB0aGUKd29ya2Fyb3VuZCBpbgpjb21taXQgYWIzYmU3M2ZhN2I0M2Y0YzM2NDhjZTI5YjVmZDY0 OWVhNTRkM2FkYgpBdXRob3I6IEltcmUgRGVhayA8aW1yZS5kZWFrQGludGVsLmNvbT4KRGF0ZTog ICBNb24gTWFyIDIgMTM6MDQ6NDEgMjAxNSArMDIwMAoKICAgIGRybS9pOTE1OiBnZW40OiB3b3Jr IGFyb3VuZCBoYW5nIGR1cmluZyBoaWJlcm5hdGlvbgoKd2UgaGFkIHRoZSBmb2xsb3dpbmcgcmVw b3J0cyBJIGtub3cgb2Ygd2l0aCB0aGUgc2FtZSBpc3N1ZToKLSBBY2VyIEFzcGlyZSAxODMwVCBi eSBJbHlhIChHZW41KSBbMV0KLSBGdWppdHN1IEZTQyBTNzExMCBieSBEaXJrIChHZW40LjUpIFsy XQotIFRoaW5rUGFkIFg2MCBieSBQYXZlbCAoR2VuNC41KSBbM10KLSBUaGlua1BhZCBUNjAgYnkg TWlra28gKEdlbjQuNSkgWzRdCi0gVGhpbmtQYWQgWDQxIGJ5IFBhdWwgKEdlbjMpIFs1XQoKQmFz ZWQgb24gdGhpcyBJIHdvdWxkIGdpdmUgdXAgb24gYSB2ZW5kb3Igc3BlY2lmaWMgYmxhY2tsaXN0 IGFuZCBhcHBseQp0aGUgd29ya2Fyb3VuZCBmb3IgYW55dGhpbmcgPCBHRU42LgoKQWJvdXQgY29t cGxldGVseSByZXZlcnRpbmcgdGhlIG9yaWdpbmFsCmNvbW1pdCBkYTJiYzFiOWRiMzM1MWFkZGQy OTNlNWI4Mjc1N2VmZTFmNzdlZDFkCkF1dGhvcjogSW1yZSBEZWFrIDxpbXJlLmRlYWtAaW50ZWwu Y29tPgpEYXRlOiAgIFRodSBPY3QgMjMgMTk6MjM6MjYgMjAxNCArMDMwMAoKICAgIGRybS9pOTE1 OiBhZGQgcG93ZXJvZmZfbGF0ZSBoYW5kbGVyCgpJIHN0aWxsIGJlbGlldmUgdGhhdCB0aGUgbm9y bWFsIHRoaW5nIHRvIGRvIGlzIHRvIHBvd2VyIG9mZiB0aGUgZGV2aWNlCmR1cmluZyBTNC4gVGhp cyBpcyB0aGUgZGVmYXVsdCBhY3Rpb24gdGFrZW4gYnkgdGhlIGtlcm5lbCdzIFBDSSBjb3JlIGZv cgpldmVyeSBkZXZpY2UuIFM0IGlzIG5vdCBhIHN0YXRlIHdoZXJlIGl0J2QgYmUgZ3VhcmFudGVl ZCB0aGF0IGFsbApkZXZpY2VzIGFyZSBwb3dlcmVkIG9mZiwgdGhlcmUgbWF5IGJlIHdha2UtdXAg ZGV2aWNlcyB0aGF0IGFyZSBzdGlsbApwb3dlcmVkIGZvciBleGFtcGxlLCBzbyBwb3dlcmluZyBv ZmYgYW55IGRldmljZXMgZXhwbGljaXRseSB0aGF0IGFyZSBub3QKd2FrZS11cCBzb3VyY2VzIG1h a2VzIHNlbnNlIHRvIG1lLiBJIHRoaW5rIHdlIG5lZWQgYSBwb2ludCB3aGVyZSB3ZSBzdG9wCmFw cGx5aW5nIHRoaXMgd29ya2Fyb3VuZCBhbmQgR0VONiBzZWVtcyBsaWtlIGEgZ29vZCBwb2ludCBm b3IgdGhhdCwKc2luY2UgSSBoYXZlbid0IHNlZW4gYW55IHJlcG9ydCBwYXN0IEdFTjUuCgotLUlt cmUKClsxXSBodHRwczovL2J1Z3ppbGxhLmtlcm5lbC5vcmcvc2hvd19idWcuY2dpP2lkPTk0MjQx I2M4ClsyXSBodHRwczovL2J1Z3ppbGxhLmtlcm5lbC5vcmcvc2hvd19idWcuY2dpP2lkPTk1MDYx ClszXSBodHRwczovL2xrbWwub3JnL2xrbWwvMjAxNS82LzE3LzQwNApbNF0gaHR0cDovL2xpc3Rz LmZyZWVkZXNrdG9wLm9yZy9hcmNoaXZlcy9pbnRlbC1nZngvMjAxNS1KdW5lLzA2OTMwNS5odG1s Cls1XSBodHRwczovL2xrbWwub3JnL2xrbWwvMjAxNS8zLzE4LzEzMwoKCl9fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QK ZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwOi8vbGlzdHMuZnJlZWRlc2t0b3Au b3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933389AbbFVNoE (ORCPT ); Mon, 22 Jun 2015 09:44:04 -0400 Received: from mga02.intel.com ([134.134.136.20]:5742 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750962AbbFVNnz (ORCPT ); Mon, 22 Jun 2015 09:43:55 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.13,659,1427785200"; d="scan'208";a="732251833" Message-ID: <1434980630.31905.88.camel@intel.com> Subject: Re: [PATCH] drm/i915: enable BIOS hang workaround for Lenovo T60 too From: Imre Deak Reply-To: imre.deak@intel.com To: Paul Bolle Cc: Daniel Vetter , Mikko Rapeli , linux-kernel@vger.kernel.org, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, Jani Nikula , Ville =?ISO-8859-1?Q?Syrj=E4l=E4?= , Ilya Tumaykin , DirkGriesbach , "Rafael J. Wysocki" Date: Mon, 22 Jun 2015 16:43:50 +0300 In-Reply-To: <1434731815.2385.157.camel@x220> References: <1434694676-2039-1-git-send-email-mikko.rapeli@iki.fi> <20150619154431.GD25769@phenom.ffwll.local> <1434731815.2385.157.camel@x220> Organization: Intel Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.12.11-0ubuntu3 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On pe, 2015-06-19 at 18:36 +0200, Paul Bolle wrote: > On Fri, 2015-06-19 at 17:44 +0200, Daniel Vetter wrote: > > I wonder whether we shouldn't do this unconditionally for gen4 and earlier > > for Lenovo ... Anyway this needs Cc: stable@vger.kernel.org and is for > > Jani to pick up. > > > > Thanks for figuring out what's been broken here. > > -Daniel > > > > > pci_set_power_state(drm_dev->pdev, PCI_D3hot); > > > > > > return 0; > > Just two days ago we discussed this bug too, see > https://lkml.org/lkml/2015/6/17/327 . That message contains a link to a > patch I cobbled together for yet another ThinkPad hitting this, but with > PCI_SUBVENDOR_ID_IBM involved. To summarize, since we extended the range of platforms to apply the workaround in commit ab3be73fa7b43f4c3648ce29b5fd649ea54d3adb Author: Imre Deak Date: Mon Mar 2 13:04:41 2015 +0200 drm/i915: gen4: work around hang during hibernation we had the following reports I know of with the same issue: - Acer Aspire 1830T by Ilya (Gen5) [1] - Fujitsu FSC S7110 by Dirk (Gen4.5) [2] - ThinkPad X60 by Pavel (Gen4.5) [3] - ThinkPad T60 by Mikko (Gen4.5) [4] - ThinkPad X41 by Paul (Gen3) [5] Based on this I would give up on a vendor specific blacklist and apply the workaround for anything < GEN6. About completely reverting the original commit da2bc1b9db3351addd293e5b82757efe1f77ed1d Author: Imre Deak Date: Thu Oct 23 19:23:26 2014 +0300 drm/i915: add poweroff_late handler I still believe that the normal thing to do is to power off the device during S4. This is the default action taken by the kernel's PCI core for every device. S4 is not a state where it'd be guaranteed that all devices are powered off, there may be wake-up devices that are still powered for example, so powering off any devices explicitly that are not wake-up sources makes sense to me. I think we need a point where we stop applying this workaround and GEN6 seems like a good point for that, since I haven't seen any report past GEN5. --Imre [1] https://bugzilla.kernel.org/show_bug.cgi?id=94241#c8 [2] https://bugzilla.kernel.org/show_bug.cgi?id=95061 [3] https://lkml.org/lkml/2015/6/17/404 [4] http://lists.freedesktop.org/archives/intel-gfx/2015-June/069305.html [5] https://lkml.org/lkml/2015/3/18/133 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in Please read the FAQ at http://www.tux.org/lkml/