Re: [PATCH] python3-cython: make generated source file be reproducible

["hongxu" <hongxu.jia@eng.windriver.com>]

[-- Attachment #1: Type: text/plain, Size: 1062 bytes --]

On Wed, Sep 17, 2025 at 05:26 AM, Gyorgy Sarvari wrote:

> 
> 
>> +diff --git a/Cython/Compiler/ModuleNode.py
>> b/Cython/Compiler/ModuleNode.py
>> +index 6672cb986..ae1625ea2 100644
>> +--- a/Cython/Compiler/ModuleNode.py
>> ++++ b/Cython/Compiler/ModuleNode.py
>> +@@ -779,7 +779,9 @@ class ModuleNode(Nodes.Node, Nodes.BlockNode):
>> + code.put_generated_by()
>> + if metadata:
>> + code.putln("/* BEGIN: Cython Metadata")
>> +- code.putln(json.dumps(metadata, indent=4, sort_keys=True))
>> ++ _metadata = json.dumps(metadata, indent=4, sort_keys=True)
>> ++ _metadata = _metadata.replace(os.getcwd()+'/', '')
> 
> I don't think that this is going to work on Windows due to the different
> default path separator (of course for Yocto that doesn't matter much,
> but I think upstream cares about it)

OK, I will use hardcode string 'build_path' to replace actual build path prefix,
it should be portable for both of Linux and Windows.

Please drop this review, v2 incomig

//Hongxu

> 
> Maybe os.path.sep would be more portable?

[-- Attachment #2: Type: text/html, Size: 1219 bytes --]