From mboxrd@z Thu Jan 1 00:00:00 1970 From: Benjamin Herrenschmidt Subject: Re: [PATCH v4 2/3] powerpc/powernv: Create LED platform device Date: Thu, 25 Jun 2015 11:05:00 +1000 Message-ID: <1435194300.3790.28.camel@kernel.crashing.org> References: <20150428100535.26912.29607.stgit@localhost.localdomain> <20150428100958.26912.78396.stgit@localhost.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20150428100958.26912.78396.stgit@localhost.localdomain> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: linuxppc-dev-bounces+glppe-linuxppc-embedded-2=m.gmane.org@lists.ozlabs.org Sender: "Linuxppc-dev" To: Vasant Hegde Cc: stewart@linux.vnet.ibm.com, j.anaszewski81@gmail.com, cooloney@gmail.com, rpurdie@rpsys.net, linuxppc-dev@lists.ozlabs.org, linux-leds@vger.kernel.org, khandual@linux.vnet.ibm.com List-Id: linux-leds@vger.kernel.org T24gVHVlLCAyMDE1LTA0LTI4IGF0IDE1OjQwICswNTMwLCBWYXNhbnQgSGVnZGUgd3JvdGU6Cj4g VGhpcyBwYXRjaCBhZGRzIHBhbHRmb3JtIGRldmljZXMgZm9yIGxlZHMuIEFsc28gZXhwb3J0IExF RCByZWxhdGVkCj4gT1BBTCBBUEkncyBzbyB0aGF0IGxlZCBkcml2ZXIgY2FuIHVzZSB0aGVzZSBB UElzLgo+IAo+IFNpZ25lZC1vZmYtYnk6IFZhc2FudCBIZWdkZSA8aGVnZGV2YXNhbnRAbGludXgu dm5ldC5pYm0uY29tPgoKQWNrZWQtYnk6IEJlbmphbWluIEhlcnJlbnNjaG1pZHQgPGJlbmhAa2Vy bmVsLmNyYXNoaW5nLm9yZz4KCgo+IC0tLQo+ICBhcmNoL3Bvd2VycGMvcGxhdGZvcm1zL3Bvd2Vy bnYvb3BhbC5jIHwgICAxMiArKysrKysrKysrKy0KPiAgMSBmaWxlIGNoYW5nZWQsIDExIGluc2Vy dGlvbnMoKyksIDEgZGVsZXRpb24oLSkKPiAKPiBkaWZmIC0tZ2l0IGEvYXJjaC9wb3dlcnBjL3Bs YXRmb3Jtcy9wb3dlcm52L29wYWwuYyBiL2FyY2gvcG93ZXJwYy9wbGF0Zm9ybXMvcG93ZXJudi9v cGFsLmMKPiBpbmRleCAyMjQxNTY1Li5iMTk1MWFhIDEwMDY0NAo+IC0tLSBhL2FyY2gvcG93ZXJw Yy9wbGF0Zm9ybXMvcG93ZXJudi9vcGFsLmMKPiArKysgYi9hcmNoL3Bvd2VycGMvcGxhdGZvcm1z L3Bvd2VybnYvb3BhbC5jCj4gQEAgLTc4NCw3ICs3ODQsNyBAQCBzdGF0aWMgdm9pZCBvcGFsX2lu aXRfaGVhcnRiZWF0KHZvaWQpCj4gIAo+ICBzdGF0aWMgaW50IF9faW5pdCBvcGFsX2luaXQodm9p ZCkKPiAgewo+IC0Jc3RydWN0IGRldmljZV9ub2RlICpucCwgKmNvbnNvbGVzOwo+ICsJc3RydWN0 IGRldmljZV9ub2RlICpucCwgKmNvbnNvbGVzLCAqbGVkOwo+ICAJaW50IHJjOwo+ICAKPiAgCW9w YWxfbm9kZSA9IG9mX2ZpbmRfbm9kZV9ieV9wYXRoKCIvaWJtLG9wYWwiKTsKPiBAQCAtODEzLDYg KzgxMywxMyBAQCBzdGF0aWMgaW50IF9faW5pdCBvcGFsX2luaXQodm9pZCkKPiAgCS8qIFNldHVw IGEgaGVhdGJlYXQgdGhyZWFkIGlmIHJlcXVlc3RlZCBieSBPUEFMICovCj4gIAlvcGFsX2luaXRf aGVhcnRiZWF0KCk7Cj4gIAo+ICsJLyogQ3JlYXRlIGxlZCBwbGF0Zm9ybSBkZXZpY2VzICovCj4g KwlsZWQgPSBvZl9maW5kX25vZGVfYnlfcGF0aCgiL2libSxvcGFsL2xlZCIpOwo+ICsJaWYgKGxl ZCkgewo+ICsJCW9mX3BsYXRmb3JtX2RldmljZV9jcmVhdGUobGVkLCAib3BhbF9sZWQiLCBOVUxM KTsKPiArCQlvZl9ub2RlX3B1dChsZWQpOwo+ICsJfQo+ICsKPiAgCS8qIEZpbmQgYWxsIE9QQUwg aW50ZXJydXB0cyBhbmQgcmVxdWVzdCB0aGVtICovCj4gIAlvcGFsX2lycV9pbml0KG9wYWxfbm9k ZSk7Cj4gIAo+IEBAIC05NzAsMyArOTc3LDYgQEAgRVhQT1JUX1NZTUJPTF9HUEwob3BhbF9ydGNf d3JpdGUpOwo+ICBFWFBPUlRfU1lNQk9MX0dQTChvcGFsX3Rwb19yZWFkKTsKPiAgRVhQT1JUX1NZ TUJPTF9HUEwob3BhbF90cG9fd3JpdGUpOwo+ICBFWFBPUlRfU1lNQk9MX0dQTChvcGFsX2kyY19y ZXF1ZXN0KTsKPiArLyogRXhwb3J0IHRoZXNlIHN5bWJvbHMgZm9yIFBvd2VyTlYgTEVEIGNsYXNz IGRyaXZlciAqLwo+ICtFWFBPUlRfU1lNQk9MX0dQTChvcGFsX2xlZHNfZ2V0X2luZCk7Cj4gK0VY UE9SVF9TWU1CT0xfR1BMKG9wYWxfbGVkc19zZXRfaW5kKTsKCgpfX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fXwpMaW51eHBwYy1kZXYgbWFpbGluZyBsaXN0Ckxp bnV4cHBjLWRldkBsaXN0cy5vemxhYnMub3JnCmh0dHBzOi8vbGlzdHMub3psYWJzLm9yZy9saXN0 aW5mby9saW51eHBwYy1kZXY= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate.crashing.org (gate.crashing.org [63.228.1.57]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 10FC31A0FBF for ; Thu, 25 Jun 2015 11:05:16 +1000 (AEST) Message-ID: <1435194300.3790.28.camel@kernel.crashing.org> Subject: Re: [PATCH v4 2/3] powerpc/powernv: Create LED platform device From: Benjamin Herrenschmidt To: Vasant Hegde Cc: linuxppc-dev@lists.ozlabs.org, linux-leds@vger.kernel.org, stewart@linux.vnet.ibm.com, j.anaszewski81@gmail.com, cooloney@gmail.com, rpurdie@rpsys.net, mpe@ellerman.id.au, khandual@linux.vnet.ibm.com Date: Thu, 25 Jun 2015 11:05:00 +1000 In-Reply-To: <20150428100958.26912.78396.stgit@localhost.localdomain> References: <20150428100535.26912.29607.stgit@localhost.localdomain> <20150428100958.26912.78396.stgit@localhost.localdomain> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Tue, 2015-04-28 at 15:40 +0530, Vasant Hegde wrote: > This patch adds paltform devices for leds. Also export LED related > OPAL API's so that led driver can use these APIs. > > Signed-off-by: Vasant Hegde Acked-by: Benjamin Herrenschmidt > --- > arch/powerpc/platforms/powernv/opal.c | 12 +++++++++++- > 1 file changed, 11 insertions(+), 1 deletion(-) > > diff --git a/arch/powerpc/platforms/powernv/opal.c b/arch/powerpc/platforms/powernv/opal.c > index 2241565..b1951aa 100644 > --- a/arch/powerpc/platforms/powernv/opal.c > +++ b/arch/powerpc/platforms/powernv/opal.c > @@ -784,7 +784,7 @@ static void opal_init_heartbeat(void) > > static int __init opal_init(void) > { > - struct device_node *np, *consoles; > + struct device_node *np, *consoles, *led; > int rc; > > opal_node = of_find_node_by_path("/ibm,opal"); > @@ -813,6 +813,13 @@ static int __init opal_init(void) > /* Setup a heatbeat thread if requested by OPAL */ > opal_init_heartbeat(); > > + /* Create led platform devices */ > + led = of_find_node_by_path("/ibm,opal/led"); > + if (led) { > + of_platform_device_create(led, "opal_led", NULL); > + of_node_put(led); > + } > + > /* Find all OPAL interrupts and request them */ > opal_irq_init(opal_node); > > @@ -970,3 +977,6 @@ EXPORT_SYMBOL_GPL(opal_rtc_write); > EXPORT_SYMBOL_GPL(opal_tpo_read); > EXPORT_SYMBOL_GPL(opal_tpo_write); > EXPORT_SYMBOL_GPL(opal_i2c_request); > +/* Export these symbols for PowerNV LED class driver */ > +EXPORT_SYMBOL_GPL(opal_leds_get_ind); > +EXPORT_SYMBOL_GPL(opal_leds_set_ind);