From: Daniel Axtens <dja@axtens.net>
To: Anshuman Khandual <khandual@linux.vnet.ibm.com>
Cc: linuxppc-dev@ozlabs.org, mpe@ellerman.id.au,
sukadev@linux.vnet.ibm.com, mikey@neuling.org
Subject: Re: [PATCH V9 02/13] powerpc, perf: Change type of the bhrb_users variable
Date: Thu, 25 Jun 2015 15:42:00 +1000 [thread overview]
Message-ID: <1435210920.4286.38.camel@axtens.net> (raw)
In-Reply-To: <1434370268-19056-3-git-send-email-khandual@linux.vnet.ibm.com>
[-- Attachment #1: Type: text/plain, Size: 575 bytes --]
> - int bhrb_users;
> + unsigned int bhrb_users;
OK, so this is a good start.
A quick git grep for bhrb_users reveals this:
perf/core-book3s.c: WARN_ON_ONCE(cpuhw->bhrb_users < 0);
That occurs in power_pmu_bhrb_disable, immediately following a decrement
of bhrb_users. Now that the test can never be true, this patch should
change the function to check if bhrb_users is 0 before decrementing.
> void *bhrb_context;
> struct perf_branch_stack bhrb_stack;
> struct perf_branch_entry bhrb_entries[BHRB_MAX_ENTRIES];
--
Regards,
Daniel
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 860 bytes --]
next prev parent reply other threads:[~2015-06-25 5:43 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-15 12:10 [PATCH V9 00/13] powerpc, perf: Enable SW branch filters Anshuman Khandual
2015-06-15 12:10 ` [PATCH V9 01/13] powerpc, perf: Drop the branch sample when 'from' cannot be fetched Anshuman Khandual
2015-06-15 12:10 ` [PATCH V9 02/13] powerpc, perf: Change type of the bhrb_users variable Anshuman Khandual
2015-06-25 5:42 ` Daniel Axtens [this message]
2015-06-25 12:51 ` Anshuman Khandual
2015-06-15 12:10 ` [PATCH V9 03/13] powerpc, perf: Replace last usage of get_cpu_var with this_cpu_ptr Anshuman Khandual
2015-06-15 12:10 ` [PATCH V9 04/13] powerpc, perf: Restore privilege level filter support for BHRB Anshuman Khandual
2015-06-25 5:02 ` Daniel Axtens
2015-06-25 12:51 ` Anshuman Khandual
2015-06-15 12:11 ` [PATCH V9 05/13] powerpc, perf: Change name & type of 'pred' in power_pmu_bhrb_read Anshuman Khandual
2015-06-25 5:11 ` Daniel Axtens
2015-06-25 12:52 ` Anshuman Khandual
2015-06-15 12:11 ` [PATCH V9 06/13] powerpc, perf: Re organize BHRB processing Anshuman Khandual
2015-06-25 5:52 ` Daniel Axtens
2015-06-25 12:52 ` Anshuman Khandual
2015-06-15 12:11 ` [PATCH V9 07/13] powerpc, perf: Re organize PMU branch filter processing on POWER8 Anshuman Khandual
2015-06-15 12:11 ` [PATCH V9 08/13] powerpc, perf: Change the name of HW PMU branch filter tracking variable Anshuman Khandual
2015-06-15 12:11 ` [PATCH V9 09/13] powerpc, lib: Add new branch analysis support functions Anshuman Khandual
2015-06-15 12:11 ` [PATCH V9 10/13] powerpc, perf: Enable SW filtering in branch stack sampling framework Anshuman Khandual
2015-06-15 12:11 ` [PATCH V9 11/13] powerpc, perf: Change POWER8 PMU configuration to work with SW filters Anshuman Khandual
2015-06-15 12:11 ` [PATCH V9 12/13] powerpc, perf: Enable privilege mode SW branch filters Anshuman Khandual
2015-06-15 12:11 ` [PATCH V9 13/13] selftests, powerpc: Add test for BHRB branch filters (HW & SW) Anshuman Khandual
2015-06-25 6:18 ` [PATCH V9 00/13] powerpc, perf: Enable SW branch filters Daniel Axtens
2015-06-25 12:50 ` Anshuman Khandual
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1435210920.4286.38.camel@axtens.net \
--to=dja@axtens.net \
--cc=khandual@linux.vnet.ibm.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=mikey@neuling.org \
--cc=mpe@ellerman.id.au \
--cc=sukadev@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.