From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH] OSSTest: some more info when capturing logs Date: Thu, 25 Jun 2015 10:27:21 +0100 Message-ID: <1435224441.32500.4.camel@citrix.com> References: <1435162282.25170.134.camel@citrix.com> <1435222098.28264.310.camel@citrix.com> <1435223479.25170.146.camel@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1435223479.25170.146.camel@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Dario Faggioli Cc: Ian Jackson , "xen-devel@lists.xen.org" List-Id: xen-devel@lists.xenproject.org On Thu, 2015-06-25 at 11:11 +0200, Dario Faggioli wrote: > On Thu, 2015-06-25 at 09:48 +0100, Ian Campbell wrote: > > On Wed, 2015-06-24 at 18:11 +0200, Dario Faggioli wrote: > > > more specifically: > > > > > > * '-n' switch to xl info, to show the topology > > > of the host, > > > > Is the information from "xl info -n" a superset of that from "xl info"? > > > Yes. > > > IOW could we just collect xl info -n and be done with it? > > > That's what the patch is doing: > > > > @@ -153,9 +153,10 @@ sub fetch_logs_host_guests () { > > > > > > foreach my $cmd > > > ( > > > - 'xl info', > > > + 'xl info -n', > > > Perhaps the changelog was not so clear... in this case, "more info" > applies right because adding '-n' adds information, wrt not using it, or > at least that was what I meant. > > Should I clarify and resend? No need, I should just learn to read a diff properly, sorry. Acked-by: Ian Campbell