Re: [PATCH 0/2] xen: Allow xen tools to run in guest using 64K page granularity

[Ian Campbell <ian.campbell@citrix.com>]

On Thu, 2015-06-25 at 11:21 +0100, Wei Liu wrote:
> On Mon, May 11, 2015 at 12:55:34PM +0100, Julien Grall wrote:
> > Hi all,
> > 
> > This small series are the only changes required in Xen in order to run a guest
> > using 64K page granularity on top of an unmodified Xen.
> > 
> > I'd like feedback from maintainers tools to know if it might be worth to
> > introduce a function xc_pagesize() replicating the behavior of getpagesize()
> > for Xen.
> > 
> 
> Can we start with documenting the ABI (?) for communicating between
> guests with different page sizes?

We should certainly make it clearer what things are in terms of "Xen ABI
page size" vs "the guest's page size" and other things.

I think we can commit these two without that though?

> 
> Or at least mention the ring mfn always has the size of XC_PAGE_SIZE (if
> that's the case).
> 
> Wei.
> 
> > Sincerely yours,
> > 
> > Julien Grall (2):
> >   tools/xenstored: Use XC_PAGE_SIZE rather than getpagesize()
> >   tools/xenconsoled: Use XC_PAGE_SIZE rather than getpagesize()
> > 
> >  tools/console/daemon/io.c         | 4 ++--
> >  tools/xenstore/xenstored_domain.c | 4 ++--
> >  2 files changed, 4 insertions(+), 4 deletions(-)
> > 
> > -- 
> > 2.1.4