All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ian Campbell <ian.campbell@citrix.com>
To: Anthony PERARD <anthony.perard@citrix.com>
Cc: Jim Fehlig <jfehlig@suse.com>, Xen Devel <xen-devel@lists.xen.org>
Subject: Re: vif-bridge: ip link set failed, "name" too long
Date: Thu, 25 Jun 2015 12:53:39 +0100	[thread overview]
Message-ID: <1435233219.32500.53.camel@citrix.com> (raw)
In-Reply-To: <20150625113648.GK3393@perard.uk.xensource.com>

On Thu, 2015-06-25 at 12:36 +0100, Anthony PERARD wrote:
> Error: argument "tap695cf459-b0-emu" is wrong: "name" too long

Under Linux IFNAMSIZ is 16, whereas this is 18 characters.

Since our suffix is "-emu" we are adding 4 to the original 14, so we
could/should pick a 2 character suffix to distinguish PV from emulated
interfaces. "-e" perhaps?

It looks like the suffix is in both 
tools/hotplug/Linux/vif-common.sh and
tools/libxl/libxl_internal.h:TAP_DEVICE_SUFFIX. We could perhaps arrange
somehow that only the hotplug scripts needed to know this, allowing this
to be a more localised decision but it would no doubt involve a bunch of
faff. I'm inclined to suggest we just change the suffix globally.

Ian.

  reply	other threads:[~2015-06-25 11:53 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-25 11:36 vif-bridge: ip link set failed, "name" too long Anthony PERARD
2015-06-25 11:53 ` Ian Campbell [this message]
2015-06-26  6:28   ` Jim Fehlig
2015-06-26  7:10     ` Ian Campbell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1435233219.32500.53.camel@citrix.com \
    --to=ian.campbell@citrix.com \
    --cc=anthony.perard@citrix.com \
    --cc=jfehlig@suse.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.