From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [v4][PATCH 12/19] tools/libxl: passes rdm reservation policy Date: Thu, 25 Jun 2015 13:15:18 +0100 Message-ID: <1435234518.32500.75.camel@citrix.com> References: <1435053450-25131-1-git-send-email-tiejun.chen@intel.com> <1435053450-25131-13-git-send-email-tiejun.chen@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1435053450-25131-13-git-send-email-tiejun.chen@intel.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Tiejun Chen Cc: Wei Liu , Stefano Stabellini , Ian Jackson , xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org On Tue, 2015-06-23 at 17:57 +0800, Tiejun Chen wrote: > This patch passes our rdm reservation policy inside libxl > when we assign a device or attach a device. > > CC: Ian Jackson > CC: Stefano Stabellini > CC: Ian Campbell > CC: Wei Liu > Signed-off-by: Tiejun Chen > --- > v4: > > * Fix one typo, s/unkwon/unknown > * In command description, we should use "[]" to indicate it's optional > for that extended xl command, pci-attach. > > docs/man/xl.pod.1 | 7 ++++++- > tools/libxl/libxl_pci.c | 10 +++++++++- > tools/libxl/xl_cmdimpl.c | 23 +++++++++++++++++++---- > tools/libxl/xl_cmdtable.c | 2 +- > 4 files changed, 35 insertions(+), 7 deletions(-) > > diff --git a/docs/man/xl.pod.1 b/docs/man/xl.pod.1 > index 4eb929d..c5c4809 100644 > --- a/docs/man/xl.pod.1 > +++ b/docs/man/xl.pod.1 > @@ -1368,10 +1368,15 @@ it will also attempt to re-bind the device to its original driver, making it > usable by Domain 0 again. If the device is not bound to pciback, it will > return success. > > -=item B I I > +=item B I I [I] > > Hot-plug a new pass-through pci device to the specified domain. > B is the PCI Bus/Device/Function of the physical device to pass-through. > +B is about how to handle conflict between reserving reserved device s/is about/specifies/ and I think s/between/while/ > +memory and guest address space. "strict" means an unsolved conflict leads to I think you mean "in" rather than "and"? > +immediate VM crash, while "relaxed" allows VM moving forward with a warning > +message thrown out. Here "strict" is default. "The default is "strict"". You've repeated the list of allowed values for this two or three times now in the various docs, perhaps try and centralise on one definition and cross reference instead?