From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <ian.campbell@citrix.com>
Subject: Re: [PATCH v2] libxl: Add AHCI support for upstream qemu
Date: Thu, 25 Jun 2015 13:18:18 +0100
Message-ID: <1435234698.32500.78.camel@citrix.com>
References: <1435050935-3094-1-git-send-email-fabio.fantoni@m2r.biz>
	<1435227693.32500.25.camel@citrix.com> <558BE2BC.2090304@m2r.biz>
	<alpine.DEB.2.02.1506251253390.4360@kaball.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <alpine.DEB.2.02.1506251253390.4360@kaball.uk.xensource.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Cc: xen-devel@lists.xensource.com, wei.liu2@citrix.com, George.Dunlap@eu.citrix.com, Ian.Jackson@eu.citrix.com, Fabio Fantoni <fabio.fantoni@m2r.biz>, anthony.perard@citrix.com, Paul.Durrant@citrix.com
List-Id: xen-devel@lists.xenproject.org

On Thu, 2015-06-25 at 12:58 +0100, Stefano Stabellini wrote:
> On Thu, 25 Jun 2015, Fabio Fantoni wrote:
> > Il 25/06/2015 12:21, Ian Campbell ha scritto:
> > > On Tue, 2015-06-23 at 11:15 +0200, Fabio Fantoni wrote:
> > > > Usage:
> > > > ahci=0|1 (default=0)
> > > I think a global rather than per disk option is OK (I can't think why a
> > > user would want to mix and match) but maybe we should consider using an
> > > enum (with values ide and ahci, defaulting to ide in libxl) so that we
> > > can add support for whatever fancy new disk controller everyone is using
> > > in 5 years time?
> > 
> > ahci was added 4 years ago in qemu and I don't know of newer similar
> > tecnology,

It maybe hasn't been invented yet (although Malcolm suggested nvme,
which is plausible).

>  in the case of enum probably shold be more generic for include more
> > future possibility or I'm wrong? in that case what can be the name?
> > @stabellini and other developer: any advice about this?
> 
> I don't know of any other block technologies that would use "hd" as
> block device names. Virtio-blk uses "vd", so it couldn't be confused.
> However for the sake of being future proof, it might make sense to
> introduce an enum, maybe something like "hdtype"?
> 
> enum hdtype {
>     ide,
>     ahci,
> }
> 
> then in the config file:
> 
> hdtype=ahci

That's the sort of thing I was imagining, yes.

Ian.