From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <ian.campbell@citrix.com>
Subject: Re: [PATCH RFC 1/9] libxl idl: add comments to error
 enum
Date: Thu, 25 Jun 2015 16:58:10 +0100
Message-ID: <1435247890.32500.100.camel@citrix.com>
References: <1435153656-19485-1-git-send-email-rob.hoes@citrix.com>
	<1435153656-19485-2-git-send-email-rob.hoes@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta5.messagelabs.com ([195.245.231.135])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <prvs=611ba0aa7=Ian.Campbell@citrix.com>)
	id 1Z89Y8-0008Sz-UV
	for xen-devel@lists.xenproject.org; Thu, 25 Jun 2015 15:58:49 +0000
In-Reply-To: <1435153656-19485-2-git-send-email-rob.hoes@citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Rob Hoes <rob.hoes@citrix.com>
Cc: xen-devel@lists.xenproject.org, euan.harris@citrix.com, Ian.Jackson@eu.citrix.com
List-Id: xen-devel@lists.xenproject.org

On Wed, 2015-06-24 at 14:47 +0100, Rob Hoes wrote:
> Signed-off-by: Rob Hoes <rob.hoes@citrix.com>
> ---
>  tools/libxl/libxl_types.idl | 41 +++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 41 insertions(+)
> 
> diff --git a/tools/libxl/libxl_types.idl b/tools/libxl/libxl_types.idl
> index 65d479f..6dc18fa 100644
> --- a/tools/libxl/libxl_types.idl
> +++ b/tools/libxl/libxl_types.idl
> @@ -44,26 +44,67 @@ MemKB = UInt(64, init_val = "LIBXL_MEMKB_DEFAULT", json_gen_fn = "libxl__uint64_
>  #
>  
>  libxl_error = Enumeration("error", [
> +    # Generic failure; code should be avoided (often seen as "rc = -1")
>      (-1, "NONSPECIFIC"),

I wonder if we should extend the Enumeration IDL support to have an
optional 3rd field (or a named param) containing a textual description,
which could then be used to autogenerate an analogue of sterrror(3) for
enums which include such things?