All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Turner <dturner@twopensource.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, mhagger@alum.mit.edu
Subject: Re: [PATCH v2 3/6] bisect: use refs infrastructure for BISECT_START
Date: Thu, 25 Jun 2015 20:22:53 -0400	[thread overview]
Message-ID: <1435278173.7900.27.camel@twopensource.com> (raw)
In-Reply-To: <1435274490.7900.19.camel@twopensource.com>

On Thu, 2015-06-25 at 19:21 -0400, David Turner wrote:
> On Thu, 2015-06-25 at 13:52 -0700, Junio C Hamano wrote:
> > David Turner <dturner@twopensource.com> writes:
> > 
> > > This ref needs to go through the refs backend, since some code assumes
> > > that it can be written and read as a ref.
> > 
> > And the reason why BISECT_HEAD cannot be treated as a ref, but must
> > be treated as a file under $GIT_DIR, is...?
> 
> After running some tests on the long version of the series, we can and
> should move it into the backend; will add a patch to the next reroll

Actually, I've looked into this further. BISECT_START isn't a ref
because it contains the ref name that the bisection started from (not a
symbolic ref).  BISECT_HEAD is a ref.  Will fix.

  reply	other threads:[~2015-06-26  0:23 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-25 20:45 [PATCH v2 1/6] refs.c: add err arguments to reflog functions David Turner
2015-06-25 20:45 ` [PATCH v2 2/6] cherry-pick: treat CHERRY_PICK_HEAD and REVERT_HEAD as refs David Turner
2015-06-25 21:11   ` Junio C Hamano
2015-06-25 22:29     ` David Turner
2015-06-25 20:45 ` [PATCH v2 3/6] bisect: use refs infrastructure for BISECT_START David Turner
2015-06-25 20:52   ` Junio C Hamano
2015-06-25 23:21     ` David Turner
2015-06-26  0:22       ` David Turner [this message]
2015-06-25 20:45 ` [PATCH v2 4/6] refs: add safe_create_reflog function David Turner
2015-06-25 21:02   ` Junio C Hamano
2015-06-25 20:45 ` [PATCH v2 5/6] git-reflog: add create and exists functions David Turner
2015-06-25 21:01   ` Junio C Hamano
2015-06-25 21:51   ` David Turner
2015-06-25 20:45 ` [PATCH v2 6/6] git-stash: use git-reflog instead of creating files David Turner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1435278173.7900.27.camel@twopensource.com \
    --to=dturner@twopensource.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=mhagger@alum.mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.