From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <ian.campbell@citrix.com>
Subject: Re: [v4][PATCH 12/19] tools/libxl: passes rdm
 reservation policy
Date: Fri, 26 Jun 2015 10:01:30 +0100
Message-ID: <1435309290.32500.143.camel@citrix.com>
References: <1435053450-25131-1-git-send-email-tiejun.chen@intel.com>
	<1435053450-25131-13-git-send-email-tiejun.chen@intel.com>
	<1435234518.32500.75.camel@citrix.com> <558D131B.9040902@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <558D131B.9040902@intel.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: "Chen, Tiejun" <tiejun.chen@intel.com>
Cc: Ian Jackson <ian.jackson@eu.citrix.com>, xen-devel@lists.xen.org, Wei Liu <wei.liu2@citrix.com>, Stefano Stabellini <stefano.stabellini@eu.citrix.com>
List-Id: xen-devel@lists.xenproject.org

On Fri, 2015-06-26 at 16:53 +0800, Chen, Tiejun wrote:
> >>   B<BDF> is the PCI Bus/Device/Function of the physical device to pass-through.
> >> +B<rdm policy> is about how to handle conflict between reserving reserved device
> >
> > s/is about/specifies/
> 
> Okay.
> 
> and I think s/between/while/
> >
> >> +memory and guest address space. "strict" means an unsolved conflict leads to
> >
> > I think you mean "in" rather than "and"?
> 
> Actually, as you see I was originally trying to say " conflict between A 
> and B".
> 
> What about this?
> 
> B<rdm policy> specifies how to handle conflict between reserved device 
> memory space and guest address space...

I'd say either "handle conflicts between" or "handle any conflict
between".

> 
> >
> >
> >> +immediate VM crash, while "relaxed" allows VM moving forward with a warning
> >> +message thrown out. Here "strict" is default.
> >
> > "The default is "strict"".
> 
> Okay.
> 
> >
> > You've repeated the list of allowed values for this two or three times
> > now in the various docs, perhaps try and centralise on one definition
> > and cross reference instead?
> >
> 
> I will delete this last sentence and add this,
> 
> Please refer "reserve" option to the rdm option in xl.cfg.5.txt.

Say "xl.cfg(5)" which is a neutral reference to the manpage in any form.